On Mon, Apr 26, 2021 at 10:00:51PM +0200, Fabio M. De Francesco wrote:

drm_send_event_helper() has not prototype, it has internal linkage and therefore it should be defined with storage class 'static'.

Signed-off-by: Fabio M. De Francesco fmdefrancesco@gmail.com

Changes from v1: As suggested by Daniel Vetter, removed unnecessary kernel-doc comments.

drivers/gpu/drm/drm_file.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index 7efbccffc2ea..a32e0d4f3604 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/drm/drm_file.c @@ -774,19 +774,15 @@ void drm_event_cancel_free(struct drm_device *dev, } EXPORT_SYMBOL(drm_event_cancel_free);

-/** +/*

• drm_send_event_helper - send DRM event to file descriptor

• • @dev: DRM device
• • @e: DRM event to deliver
• • @timestamp: timestamp to set for the fence event in kernel's CLOCK_MONOTONIC
• • time domain
• • This helper function sends the event @e, initialized with

• • This helper function sends the event e, initialized with

Sorry I wasn't clear, I don't think there's anything useful at all in this comment, so best to entirely remove it. Not just the kerneldoc header. Can you pls respin? -Daniel

• drm_event_reserve_init(), to its associated userspace DRM file.
• The timestamp variant of dma_fence_signal is used when the caller
• sends a valid timestamp.

*/ -void drm_send_event_helper(struct drm_device *dev, +static void drm_send_event_helper(struct drm_device *dev, struct drm_pending_event *e, ktime_t timestamp) { assert_spin_locked(&dev->event_lock); -- 2.31.1