Hi,
The i2c drivers also do not have to set 'owner' field because i2c_register_driver() will do it instead.
'owner' is removed from i2c drivers, which I was able to compile with allyesconfig (arm, arm64, i386, x86_64, ppc64). Only compile-tested.
The coccinelle script which generated the patch was sent here: http://www.spinics.net/lists/kernel/msg2029903.html
Best regards, Krzysztof
Krzysztof Kozlowski (2): drm/bridge: Drop owner assignment from i2c_driver drm/rockchip: Drop owner assignment from platform_driver
drivers/gpu/drm/bridge/ps8622.c | 1 - drivers/gpu/drm/bridge/ptn3460.c | 1 - drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - 3 files changed, 3 deletions(-)
i2c_driver does not need to set an owner because i2c_register_driver() will set it.
Signed-off-by: Krzysztof Kozlowski k.kozlowski@samsung.com
---
The coccinelle script which generated the patch was sent here: http://www.spinics.net/lists/kernel/msg2029903.html
Changes since v1: 1. Split owner removal from rockchip to separate patch (spotted by Mark Yao). --- drivers/gpu/drm/bridge/ps8622.c | 1 - drivers/gpu/drm/bridge/ptn3460.c | 1 - 2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ps8622.c b/drivers/gpu/drm/bridge/ps8622.c index 1a6607beb29f..be881e9fef8f 100644 --- a/drivers/gpu/drm/bridge/ps8622.c +++ b/drivers/gpu/drm/bridge/ps8622.c @@ -668,7 +668,6 @@ static struct i2c_driver ps8622_driver = { .remove = ps8622_remove, .driver = { .name = "ps8622", - .owner = THIS_MODULE, .of_match_table = ps8622_devices, }, }; diff --git a/drivers/gpu/drm/bridge/ptn3460.c b/drivers/gpu/drm/bridge/ptn3460.c index 1b1bf2384815..0ffa3a6a206a 100644 --- a/drivers/gpu/drm/bridge/ptn3460.c +++ b/drivers/gpu/drm/bridge/ptn3460.c @@ -400,7 +400,6 @@ static struct i2c_driver ptn3460_driver = { .remove = ptn3460_remove, .driver = { .name = "nxp,ptn3460", - .owner = THIS_MODULE, .of_match_table = ptn3460_match, }, };
platform_driver does not need to set an owner because platform_driver_register() will set it.
Signed-off-by: Krzysztof Kozlowski k.kozlowski@samsung.com
--- Changes since v1: 1. Split owner removal from rockchip to separate patch (spotted by Mark Yao). --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 01b558fe3695..9a0c2911272a 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -555,7 +555,6 @@ static struct platform_driver rockchip_drm_platform_driver = { .probe = rockchip_drm_platform_probe, .remove = rockchip_drm_platform_remove, .driver = { - .owner = THIS_MODULE, .name = "rockchip-drm", .of_match_table = rockchip_drm_dt_ids, .pm = &rockchip_drm_pm_ops,
On 2015年07月10日 18:37, Krzysztof Kozlowski wrote:
platform_driver does not need to set an owner because platform_driver_register() will set it.
Signed-off-by: Krzysztof Kozlowski k.kozlowski@samsung.com
Changes since v1:
- Split owner removal from rockchip to separate patch (spotted by Mark Yao).
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 01b558fe3695..9a0c2911272a 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -555,7 +555,6 @@ static struct platform_driver rockchip_drm_platform_driver = { .probe = rockchip_drm_platform_probe, .remove = rockchip_drm_platform_remove, .driver = {
.owner = THIS_MODULE,
Thanks for the fix, applied to my drm-next branch, :-)
dri-devel@lists.freedesktop.org
-
Krzysztof Kozlowski -
Mark yao