Failing to do so meant that we got a resume() callback on first use of the device, so we would leak the bin BO that we allocated during probe.
Signed-off-by: Eric Anholt eric@anholt.net Fixes: 553c942f8b2c ("drm/vc4: Allow using more than 256MB of CMA memory.") --- drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index e3d5c59dbd4a..825a8462a63b 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -403,6 +403,7 @@ static int vc4_v3d_bind(struct device *dev, struct device *master, void *data) return ret; }
+ pm_runtime_set_active(dev); pm_runtime_use_autosuspend(dev); pm_runtime_set_autosuspend_delay(dev, 40); /* a little over 2 frames. */ pm_runtime_enable(dev);
On Mon, 15 May 2017 10:16:15 -0700 Eric Anholt eric@anholt.net wrote:
Failing to do so meant that we got a resume() callback on first use of the device, so we would leak the bin BO that we allocated during probe.
Signed-off-by: Eric Anholt eric@anholt.net Fixes: 553c942f8b2c ("drm/vc4: Allow using more than 256MB of CMA memory.")
Reviewed-by: Boris Brezillon boris.brezillon@free-electrons.com
drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index e3d5c59dbd4a..825a8462a63b 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -403,6 +403,7 @@ static int vc4_v3d_bind(struct device *dev, struct device *master, void *data) return ret; }
- pm_runtime_set_active(dev); pm_runtime_use_autosuspend(dev); pm_runtime_set_autosuspend_delay(dev, 40); /* a little over 2 frames. */ pm_runtime_enable(dev);
dri-devel@lists.freedesktop.org
-
Boris Brezillon -
Eric Anholt