fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com --- drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index b31d750..844cb0b 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -4326,7 +4326,7 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
- err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler, + err = request_threaded_irq(te_irq | IRQF_ONESHOT, NULL, omap_dsi_te_irq_handler, IRQF_TRIGGER_RISING, "TE", dsi); if (err) { dev_err(dsi->dev, "request irq failed with %d\n", err);
On Mon, 22 Mar 2021 at 09:53, Yang Li yang.lee@linux.alibaba.com wrote:
fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com
drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index b31d750..844cb0b 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -4326,7 +4326,7 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
err = request_threaded_irq(te_irq | IRQF_ONESHOT, NULL, omap_dsi_te_irq_handler, IRQF_TRIGGER_RISING, "TE", dsi);
Did you test it? There are several patches like this all over the tree so it looks like "let's fix everything from Coccinelle". It's a trend recently... multiple people send these patches. The point is that you should not blindly follow coccinelle but adjust the change for real case (e.g. is it a nested interrupt). Without this consideration and testing - NACK.
Best regards, Krzysztof
I am so sorry for my mistakes. I am a newbie trying to learn how to fix errors found by Coccinelle.
Currently, I just run scripts/checkpatch.pl. I will do basic build with the patch before sending it in the next time. Thank you for your advice.
------------------------------------------------------------------ 发件人：Krzysztof Kozlowski krzk@kernel.org 发送时间：2021年4月16日(星期五) 17:07 收件人：Yang Li yang.lee@linux.alibaba.com 抄 送：tomba tomba@kernel.org; airlied airlied@linux.ie; daniel daniel@ffwll.ch; dri-devel dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org linux-kernel@vger.kernel.org 主 题：Re: [PATCH] drm/omap: dsi: Add missing IRQF_ONESHOT
On Mon, 22 Mar 2021 at 09:53, Yang Li yang.lee@linux.alibaba.com wrote:
fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com
drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index b31d750..844cb0b 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -4326,7 +4326,7 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
err = request_threaded_irq(te_irq | IRQF_ONESHOT, NULL, omap_dsi_te_irq_handler, IRQF_TRIGGER_RISING, "TE", dsi);
Did you test it? There are several patches like this all over the tree so it looks like "let's fix everything from Coccinelle". It's a trend recently... multiple people send these patches. The point is that you should not blindly follow coccinelle but adjust the change for real case (e.g. is it a nested interrupt). Without this consideration and testing - NACK.
Best regards, Krzysztof
dri-devel@lists.freedesktop.org
-
Krzysztof Kozlowski -
Yang Li -
Yang.Lee