Thanks.

On Thu, Feb 14, 2019 at 2:27 AM Laura Abbott labbott@redhat.com wrote:

On 2/11/19 11:09 PM, Jing Xia wrote:

...

gfp_flags is always set high_order_gfp_flags even if allocations of order 0 are made.But for smaller allocations, the system should be able to reclaim some memory.

Signed-off-by: Jing Xia jing.xia@unisoc.com Reviewed-by: Yuming Han yuming.han@unisoc.com Reviewed-by: Zhaoyang Huang zhaoyang.huang@unisoc.com Reviewed-by: Orson Zhai orson.zhai@unisoc.com

---

drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c index 0383f75..20f2103 100644 --- a/drivers/staging/android/ion/ion_system_heap.c +++ b/drivers/staging/android/ion/ion_system_heap.c @@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools) static int ion_system_heap_create_pools(struct ion_page_pool **pools) { int i;

• gfp_t gfp_flags = low_order_gfp_flags;
  
  for (i = 0; i < NUM_ORDERS; i++) {
          struct ion_page_pool *pool;
  

•         gfp_t gfp_flags = low_order_gfp_flags;
  
          if (orders[i] > 4)
                  gfp_flags = high_order_gfp_flags;
  
  

This was already submitted in https://lore.kernel.org/lkml/1549004386-38778-1-git-send-email-saberlily.xia... (I'm also very behind on Ion e-mail and need to catch up...)

Laura