From: Palmer Dabbelt palmerdabbelt@google.com
cdn_dp_resume is only used under PM_SLEEP, and now that it's static an unused function warning is triggered undner !PM_SLEEP. This marks the function as possibly unused, to avoid triggering compiler warnings.
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static") Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be Signed-off-by: Palmer Dabbelt palmerdabbelt@google.com --- This is breaking my builds and looks like it'll land after -rc1, so I've put it on a shared tag for-rockchip-cdn_dp_resume-v2 which will let me pull it in to my fixes. LMK if you guys want me to send this up on my own, but I'm assuming that the drm/rockchip folks will handle it. --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index 8ab3247dbc4a..13c6b857158f 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -1123,7 +1123,7 @@ static int cdn_dp_suspend(struct device *dev) return ret; }
-static int cdn_dp_resume(struct device *dev) +static __maybe_unused int cdn_dp_resume(struct device *dev) { struct cdn_dp_device *dp = dev_get_drvdata(dev);
On Fri, 10 Sep 2021 20:43:18 -0700, Palmer Dabbelt wrote:
cdn_dp_resume is only used under PM_SLEEP, and now that it's static an unused function warning is triggered undner !PM_SLEEP. This marks the function as possibly unused, to avoid triggering compiler warnings.
Applied, thanks!
[1/1] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning commit: f7c57a4566115657c16fd6603b6ef8a21bae5194
Best regards,
On Tue, 21 Sep 2021 02:12:17 PDT (-0700), heiko@sntech.de wrote:
On Fri, 10 Sep 2021 20:43:18 -0700, Palmer Dabbelt wrote:
cdn_dp_resume is only used under PM_SLEEP, and now that it's static an unused function warning is triggered undner !PM_SLEEP. This marks the function as possibly unused, to avoid triggering compiler warnings.
Applied, thanks!
[1/1] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning commit: f7c57a4566115657c16fd6603b6ef8a21bae5194
I'm not quite sure where that lives, but is it applied on top of something or is it merged from the tag? Like I said a bit below this in the original patch, this has started to break the build for me and I'd like to pull it in as soon as possible.
Hi,
Am Dienstag, 21. September 2021, 17:04:10 CEST schrieb Palmer Dabbelt:
On Tue, 21 Sep 2021 02:12:17 PDT (-0700), heiko@sntech.de wrote:
On Fri, 10 Sep 2021 20:43:18 -0700, Palmer Dabbelt wrote:
cdn_dp_resume is only used under PM_SLEEP, and now that it's static an unused function warning is triggered undner !PM_SLEEP. This marks the function as possibly unused, to avoid triggering compiler warnings.
Applied, thanks!
[1/1] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning commit: f7c57a4566115657c16fd6603b6ef8a21bae5194
I'm not quite sure where that lives, but is it applied on top of something or is it merged from the tag? Like I said a bit below this in the original patch, this has started to break the build for me and I'd like to pull it in as soon as possible.
The patch now lives here: https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=f7...
This is the drm-misc tree, with the patch living in the drm-misc-fixes branch, which targets the current rc-kernels.
drm-misc-* moves into the core drm tree and from there on to Linus.
Hope that helps Heiko
dri-devel@lists.freedesktop.org