Hi Jyri,

Thank you for the patch.

On Tuesday 30 June 2015 13:30:55 Jyri Sarha wrote:

There is nothing special about tilcdc HW when the video memory is concerned. Just using the standard drm helpers for implementation is enough.

Signed-off-by: Jyri Sarha jsarha@ti.com

This looks simple, I like it :-)

Acked-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

---

drivers/gpu/drm/tilcdc/tilcdc_drv.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 0f283a3..4908c1f 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -553,7 +553,8 @@ static const struct file_operations fops = { };

static struct drm_driver tilcdc_driver = {

• .driver_features = DRIVER_HAVE_IRQ | DRIVER_GEM | DRIVER_MODESET,

• .driver_features = (DRIVER_HAVE_IRQ | DRIVER_GEM | DRIVER_MODESET |

• 	       DRIVER_PRIME),
  

  .load = tilcdc_load, .unload = tilcdc_unload, .preclose = tilcdc_preclose,

@@ -571,6 +572,16 @@ static struct drm_driver tilcdc_driver = { .dumb_create = drm_gem_cma_dumb_create, .dumb_map_offset = drm_gem_cma_dumb_map_offset, .dumb_destroy = drm_gem_dumb_destroy,

• .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
• .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
• .gem_prime_import = drm_gem_prime_import,
• .gem_prime_export = drm_gem_prime_export,
• .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
• .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
• .gem_prime_vmap = drm_gem_cma_prime_vmap,
• .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
• .gem_prime_mmap = drm_gem_cma_prime_mmap,

#ifdef CONFIG_DEBUG_FS .debugfs_init = tilcdc_debugfs_init, .debugfs_cleanup = tilcdc_debugfs_cleanup,