This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de --- drivers/gpu/drm/vgem/vgem_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 0e5620f76ee0..ec6af8b920da 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -504,7 +504,7 @@ static int __init vgem_init(void) static void __exit vgem_exit(void) { drm_dev_unregister(&vgem_device->drm); - drm_dev_unref(&vgem_device->drm); + drm_dev_put(&vgem_device->drm); }
module_init(vgem_init);
On Mon, Jul 16, 2018 at 1:16 PM, Thomas Zimmermann tzimmermann@suse.de wrote:
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de
drivers/gpu/drm/vgem/vgem_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 0e5620f76ee0..ec6af8b920da 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -504,7 +504,7 @@ static int __init vgem_init(void) static void __exit vgem_exit(void) { drm_dev_unregister(&vgem_device->drm);
drm_dev_unref(&vgem_device->drm);
drm_dev_put(&vgem_device->drm);}
module_init(vgem_init);
2.18.0
There are other gpu/drm drivers where drm_dev_unref is used. Do we need to replace drm_dev_unref with drm_dev_put in other places as well ?
Hi
There are other gpu/drm drivers where drm_dev_unref is used. Do we need to replace drm_dev_unref with drm_dev_put in other places as well ?
Yes. This is some overall clean-up work that I do as a side project. I already have patches for all drivers, but I found that sending them one-by-one gives a much better chance of getting them applied.
Best regards Thomas
On Mon, Jul 16, 2018 at 09:46:24AM +0200, Thomas Zimmermann wrote:
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de
Applied to drm-misc-next, thanks for your patch. -Daniel
drivers/gpu/drm/vgem/vgem_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 0e5620f76ee0..ec6af8b920da 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -504,7 +504,7 @@ static int __init vgem_init(void) static void __exit vgem_exit(void) { drm_dev_unregister(&vgem_device->drm);
- drm_dev_unref(&vgem_device->drm);
- drm_dev_put(&vgem_device->drm);
}
module_init(vgem_init);
2.18.0
dri-devel@lists.freedesktop.org
-
Daniel Vetter -
Souptick Joarder -
Thomas Zimmermann