[BISECTED] commit 619efb1059 makes the MacBookPro2,2 screen flicker like its broken or half plugged in
With the current HEAD Im getting screen flickering really bad to point where it looks like the screen is damaged and/or half plugged-in etc..
the bisect pointed to here:
commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
doing a git revert 619efb10592 gets the screen working properly again. I havent looked much through the code to see if I can fix this. for the time being I'll revert this on my machine with the current, until later on.
lspci -vv shows my card info(let me know if you need anymore)
01:00.0 VGA compatible controller: ATI Technologies Inc M56P [Radeon Mobility X1600] (prog-if 00 [VGA controller]) Subsystem: Apple Computer Inc. MacBook Pro Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin A routed to IRQ 42 Region 0: Memory at 40000000 (32-bit, prefetchable) [size=128M] Region 1: I/O ports at 3000 [size=256] Region 2: Memory at 50300000 (32-bit, non-prefetchable) [size=64K] Expansion ROM at 50320000 [disabled] [size=128K] Capabilities: <access denied> Kernel driver in use: radeon Kernel modules: radeon
Justin P. Mattock
On Tue, Feb 8, 2011 at 3:52 PM, Justin P. Mattock justinmattock@gmail.com wrote:
With the current HEAD Im getting screen flickering really bad to point where it looks like the screen is damaged and/or half plugged-in etc..
the bisect pointed to here:
commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
doing a git revert 619efb10592 gets the screen working properly again. I havent looked much through the code to see if I can fix this. for the time being I'll revert this on my machine with the current, until later on.
The attached patch should fix it assuming I got your pci ids correct. I'm done with the pll stuff; too may fixes break other boards. Just add a quirk table and be done with it.
Alex
lspci -vv shows my card info(let me know if you need anymore)
01:00.0 VGA compatible controller: ATI Technologies Inc M56P [Radeon Mobility X1600] (prog-if 00 [VGA controller]) Subsystem: Apple Computer Inc. MacBook Pro Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin A routed to IRQ 42 Region 0: Memory at 40000000 (32-bit, prefetchable) [size=128M] Region 1: I/O ports at 3000 [size=256] Region 2: Memory at 50300000 (32-bit, non-prefetchable) [size=64K] Expansion ROM at 50320000 [disabled] [size=128K] Capabilities: <access denied> Kernel driver in use: radeon Kernel modules: radeon
Justin P. Mattock
On Feb 8, 2011, at 1:20 PM, Alex Deucher wrote:
On Tue, Feb 8, 2011 at 3:52 PM, Justin P. Mattock justinmattock@gmail.com wrote:
With the current HEAD Im getting screen flickering really bad to point where it looks like the screen is damaged and/or half plugged-in etc..
the bisect pointed to here:
commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
doing a git revert 619efb10592 gets the screen working properly again. I havent looked much through the code to see if I can fix this. for the time being I'll revert this on my machine with the current, until later on.
The attached patch should fix it assuming I got your pci ids correct. I'm done with the pll stuff; too may fixes break other boards. Just add a quirk table and be done with it.
Alex
lspci -vv shows my card info(let me know if you need anymore)
01:00.0 VGA compatible controller: ATI Technologies Inc M56P [Radeon Mobility X1600] (prog-if 00 [VGA controller]) Subsystem: Apple Computer Inc. MacBook Pro Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin A routed to IRQ 42 Region 0: Memory at 40000000 (32-bit, prefetchable) [size=128M] Region 1: I/O ports at 3000 [size=256] Region 2: Memory at 50300000 (32-bit, non-prefetchable) [size=64K] Expansion ROM at 50320000 [disabled] [size=128K] Capabilities: <access denied> Kernel driver in use: radeon Kernel modules: radeon
Justin P. Mattock
<0001-drm-radeon-kms-fix-pll-algo-quirk-function.patch>
cool... The patch fixes it over here
Reported-and-Tested by: Justin P. Mattockjustinmattock@gmail.com
Thanks..
Justin P. Mattock
On Tue, Feb 8, 2011 at 4:20 PM, Alex Deucher alexdeucher@gmail.com wrote:
On Tue, Feb 8, 2011 at 3:52 PM, Justin P. Mattock justinmattock@gmail.com wrote:
With the current HEAD Im getting screen flickering really bad to point where it looks like the screen is damaged and/or half plugged-in etc..
the bisect pointed to here:
commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
doing a git revert 619efb10592 gets the screen working properly again. I havent looked much through the code to see if I can fix this. for the time being I'll revert this on my machine with the current, until later on.
The attached patch should fix it assuming I got your pci ids correct. I'm done with the pll stuff; too may fixes break other boards. Just add a quirk table and be done with it.
The attached patch builds on the previous one and fixes an additional regression.
Alex
Alex
lspci -vv shows my card info(let me know if you need anymore)
01:00.0 VGA compatible controller: ATI Technologies Inc M56P [Radeon Mobility X1600] (prog-if 00 [VGA controller]) Subsystem: Apple Computer Inc. MacBook Pro Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin A routed to IRQ 42 Region 0: Memory at 40000000 (32-bit, prefetchable) [size=128M] Region 1: I/O ports at 3000 [size=256] Region 2: Memory at 50300000 (32-bit, non-prefetchable) [size=64K] Expansion ROM at 50320000 [disabled] [size=128K] Capabilities: <access denied> Kernel driver in use: radeon Kernel modules: radeon
Justin P. Mattock
On Feb 9, 2011, at 2:09 PM, Alex Deucher wrote:
On Tue, Feb 8, 2011 at 4:20 PM, Alex Deucher alexdeucher@gmail.com wrote:
On Tue, Feb 8, 2011 at 3:52 PM, Justin P. Mattock justinmattock@gmail.com wrote:
With the current HEAD Im getting screen flickering really bad to point where it looks like the screen is damaged and/or half plugged-in etc..
the bisect pointed to here:
commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
doing a git revert 619efb10592 gets the screen working properly again. I havent looked much through the code to see if I can fix this. for the time being I'll revert this on my machine with the current, until later on.
The attached patch should fix it assuming I got your pci ids correct. I'm done with the pll stuff; too may fixes break other boards. Just add a quirk table and be done with it.
The attached patch builds on the previous one and fixes an additional regression.
Alex
<0001-drm-radeon-kms-pll-quirk-cleanup.patch>
alright... didn't mean to keep you waiting(out of my office for most of the day).. Anyways patch applied, and everything looks good no screen jitters or flickering etc..
Reported-and-Tested-by: Justin P. Mattockjustinmattock@gmail.com
Thanks for sending this my way so my machine works..
cheers,
Justin P. Mattock
On Thu, Feb 10, 2011 at 12:33 AM, Justin Mattock justinmattock@gmail.com wrote:
On Feb 9, 2011, at 2:09 PM, Alex Deucher wrote:
On Tue, Feb 8, 2011 at 4:20 PM, Alex Deucher alexdeucher@gmail.com wrote:
On Tue, Feb 8, 2011 at 3:52 PM, Justin P. Mattock justinmattock@gmail.com wrote:
With the current HEAD Im getting screen flickering really bad to point where it looks like the screen is damaged and/or half plugged-in etc..
the bisect pointed to here:
commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
doing a git revert 619efb10592 gets the screen working properly again. I havent looked much through the code to see if I can fix this. for the time being I'll revert this on my machine with the current, until later on.
The attached patch should fix it assuming I got your pci ids correct. I'm done with the pll stuff; too may fixes break other boards. Just add a quirk table and be done with it.
The attached patch builds on the previous one and fixes an additional regression.
Alex
<0001-drm-radeon-kms-pll-quirk-cleanup.patch>
alright... didn't mean to keep you waiting(out of my office for most of the day).. Anyways patch applied, and everything looks good no screen jitters or flickering etc..
Reported-and-Tested-by: Justin P. Mattockjustinmattock@gmail.com
Thanks for sending this my way so my machine works..
Justin, can you try without these patches, but with the following patch instead?
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index cc6bdd8..2f9d113 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c @@ -562,7 +562,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, } } /* this might work properly with the new pll algo */ -#if 0 /* doesn't work properly on some laptops */ +#if 1 /* doesn't work properly on some laptops */ /* use recommended ref_div for ss */ if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) { if (ss_enabled) {
cheers,
Justin P. Mattock
On Fri, Feb 11, 2011 at 1:59 AM, Alex Deucher alexdeucher@gmail.com wrote:
On Thu, Feb 10, 2011 at 12:33 AM, Justin Mattock justinmattock@gmail.com wrote:
On Feb 9, 2011, at 2:09 PM, Alex Deucher wrote:
On Tue, Feb 8, 2011 at 4:20 PM, Alex Deucher alexdeucher@gmail.com wrote:
On Tue, Feb 8, 2011 at 3:52 PM, Justin P. Mattock justinmattock@gmail.com wrote:
With the current HEAD Im getting screen flickering really bad to point where it looks like the screen is damaged and/or half plugged-in etc..
the bisect pointed to here:
commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
doing a git revert 619efb10592 gets the screen working properly again. I havent looked much through the code to see if I can fix this. for the time being I'll revert this on my machine with the current, until later on.
The attached patch should fix it assuming I got your pci ids correct. I'm done with the pll stuff; too may fixes break other boards. Just add a quirk table and be done with it.
The attached patch builds on the previous one and fixes an additional regression.
Alex
<0001-drm-radeon-kms-pll-quirk-cleanup.patch>
alright... didn't mean to keep you waiting(out of my office for most of the day).. Anyways patch applied, and everything looks good no screen jitters or flickering etc..
Reported-and-Tested-by: Justin P. Mattockjustinmattock@gmail.com
Thanks for sending this my way so my machine works..
Justin, can you try without these patches, but with the following patch instead?
Better yet, can you try the attached patch on top of 2.6.38-rc4 or newer?
Alex
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index cc6bdd8..2f9d113 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c @@ -562,7 +562,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, } } /* this might work properly with the new pll algo */ -#if 0 /* doesn't work properly on some laptops */ +#if 1 /* doesn't work properly on some laptops */ /* use recommended ref_div for ss */ if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) { if (ss_enabled) {
cheers,
Justin P. Mattock
Better yet, can you try the attached patch on top of 2.6.38-rc4 or newer?
Alex
o.k. applied that patch... unfortunately Im seeing the flickering screen and the crud shows up.. initially during boot everything looked fine, its when I suspended the machine, upon wake-up the flickering occurred. kernel version is the current: 2.6.38-rc4-00107-gaa502b4
Justin P. Mattock
On Fri, Feb 11, 2011 at 10:57 AM, Justin Mattock justinmattock@gmail.com wrote:
Better yet, can you try the attached patch on top of 2.6.38-rc4 or newer?
Alex
o.k. applied that patch... unfortunately Im seeing the flickering screen and the crud shows up.. initially during boot everything looked fine, its when I suspended the machine, upon wake-up the flickering occurred. kernel version is the current: 2.6.38-rc4-00107-gaa502b4
Can you try the following patch on top of the first two patches I posted to this thread?
Thanks,
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index cc6bdd8..2f9d113 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c @@ -562,7 +562,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, } } /* this might work properly with the new pll algo */ -#if 0 /* doesn't work properly on some laptops */ +#if 1 /* doesn't work properly on some laptops */ /* use recommended ref_div for ss */ if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) { if (ss_enabled) {
Justin P. Mattock
On Fri, Feb 11, 2011 at 10:57 AM, Justin Mattock justinmattock@gmail.com wrote:
Better yet, can you try the attached patch on top of 2.6.38-rc4 or newer?
Alex
o.k. applied that patch... unfortunately Im seeing the flickering screen and the crud shows up.. initially during boot everything looked fine, its when I suspended the machine, upon wake-up the flickering occurred. kernel version is the current: 2.6.38-rc4-00107-gaa502b4
Can you try this patch? Try uncommenting the following lines to see if either of those flags work any better. Try them individually and together if possible and report back which, if any, helps.
/*pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;*/
/*if (ASIC_IS_AVIVO(rdev)) pll->flags |= RADEON_PLL_USE_FRAC_FB_DIV;*/
Thanks!
Alex
Justin P. Mattock
On Feb 11, 2011, at 5:15 PM, Alex Deucher wrote:
On Fri, Feb 11, 2011 at 10:57 AM, Justin Mattock justinmattock@gmail.com wrote:
Better yet, can you try the attached patch on top of 2.6.38-rc4 or newer?
Alex
o.k. applied that patch... unfortunately Im seeing the flickering screen and the crud shows up.. initially during boot everything looked fine, its when I suspended the machine, upon wake-up the flickering occurred. kernel version is the current: 2.6.38-rc4-00107-gaa502b4
Can you try this patch? Try uncommenting the following lines to see if either of those flags work any better. Try them individually and together if possible and report back which, if any, helps.
/*pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;*/
/*if (ASIC_IS_AVIVO(rdev)) pll->flags |= RADEON_PLL_USE_FRAC_FB_DIV;*/
Thanks!
Alex
Justin P. Mattock
<0001-drm-radeon-kms-hopefully-fix-pll-issues-for-real-v2.patch>
alright.. again out of my office trying to make a living!! Anyways I applied the two earlier patches, and added the previous post's patch as well (everything runs o.k. s2r etc...) I can try for the above and see if I can pinpoint the piece of code that is causing this(hopefully)
Justin P. Mattock
On Sun, Feb 13, 2011 at 12:28 AM, Justin Mattock justinmattock@gmail.com wrote:
On Feb 11, 2011, at 5:15 PM, Alex Deucher wrote:
On Fri, Feb 11, 2011 at 10:57 AM, Justin Mattock justinmattock@gmail.com wrote:
Better yet, can you try the attached patch on top of 2.6.38-rc4 or newer?
Alex
o.k. applied that patch... unfortunately Im seeing the flickering screen and the crud shows up.. initially during boot everything looked fine, its when I suspended the machine, upon wake-up the flickering occurred. kernel version is the current: 2.6.38-rc4-00107-gaa502b4
Can you try this patch? Try uncommenting the following lines to see if either of those flags work any better. Try them individually and together if possible and report back which, if any, helps.
/*pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;*/
/*if (ASIC_IS_AVIVO(rdev)) pll->flags |= RADEON_PLL_USE_FRAC_FB_DIV;*/
Thanks!
Alex
Justin P. Mattock
<0001-drm-radeon-kms-hopefully-fix-pll-issues-for-real-v2.patch>
alright.. again out of my office trying to make a living!! Anyways I applied the two earlier patches, and added the previous post's patch as well (everything runs o.k. s2r etc...) I can try for the above and see if I can pinpoint the piece of code that is causing this(hopefully)
The attached patch is what I'm proposing to go upstream. Please test and let me know if it works ok for you.
Alex
Justin P. Mattock
The attached patch is what I'm proposing to go upstream. Please test and let me know if it works ok for you.
Alex
o.k.!! I have 6 revisions to test on another issue, then I can throw this in and let you know..
Justin P. Mattock
On Feb 13, 2011, at 3:46 PM, Alex Deucher wrote:
On Sun, Feb 13, 2011 at 12:28 AM, Justin Mattock justinmattock@gmail.com wrote:
On Feb 11, 2011, at 5:15 PM, Alex Deucher wrote:
On Fri, Feb 11, 2011 at 10:57 AM, Justin Mattock justinmattock@gmail.com wrote:
Better yet, can you try the attached patch on top of 2.6.38-rc4 or newer?
Alex
o.k. applied that patch... unfortunately Im seeing the flickering screen and the crud shows up.. initially during boot everything looked fine, its when I suspended the machine, upon wake-up the flickering occurred. kernel version is the current: 2.6.38-rc4-00107-gaa502b4
Can you try this patch? Try uncommenting the following lines to see if either of those flags work any better. Try them individually and together if possible and report back which, if any, helps.
/*pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;*/
/*if (ASIC_IS_AVIVO(rdev)) pll->flags |= RADEON_PLL_USE_FRAC_FB_DIV;*/
Thanks!
Alex
Justin P. Mattock
<0001-drm-radeon-kms-hopefully-fix-pll-issues-for-real-v2.patch>
alright.. again out of my office trying to make a living!! Anyways I applied the two earlier patches, and added the previous post's patch as well (everything runs o.k. s2r etc...) I can try for the above and see if I can pinpoint the piece of code that is causing this(hopefully)
The attached patch is what I'm proposing to go upstream. Please test and let me know if it works ok for you.
Alex
alright... bisect done, but something went wrong(must redu later).. Anyways with your patch applied everything looks good
Justin P. Mattock
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Justin Mattock -
Justin P. Mattock