Fix to return error code -ENOMEM from the vmalloc() error handling case instead of 0, as done elsewhere in this function.
Fixes: aec9e12953e7 ("drm/mgag200: Fix error handling paths in fbdev driver") Signed-off-by: Wei Yongjun weiyj.lk@gmail.com --- drivers/gpu/drm/mgag200/mgag200_fb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index 81325f6..88dd221 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu/drm/mgag200/mgag200_fb.c @@ -183,8 +183,10 @@ static int mgag200fb_create(struct drm_fb_helper *helper, }
sysram = vmalloc(size); - if (!sysram) + if (!sysram) { + ret = -ENOMEM; goto err_sysram; + }
info = drm_fb_helper_alloc_fbi(helper); if (IS_ERR(info)) {
On Mon, Aug 15, 2016 at 03:03:51PM +0000, Wei Yongjun wrote:
Fix to return error code -ENOMEM from the vmalloc() error handling case instead of 0, as done elsewhere in this function.
Fixes: aec9e12953e7 ("drm/mgag200: Fix error handling paths in fbdev driver") Signed-off-by: Wei Yongjun weiyj.lk@gmail.com
Applied to drm-misc, thanks. -Daniel
drivers/gpu/drm/mgag200/mgag200_fb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index 81325f6..88dd221 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu/drm/mgag200/mgag200_fb.c @@ -183,8 +183,10 @@ static int mgag200fb_create(struct drm_fb_helper *helper, }
sysram = vmalloc(size);
- if (!sysram)
if (!sysram) {
ret = -ENOMEM;
goto err_sysram;
}
info = drm_fb_helper_alloc_fbi(helper); if (IS_ERR(info)) {
dri-devel@lists.freedesktop.org