dropped the old "fsl,panel" property, using the of_graph dt binding syntax
Signed-off-by: Meng Yi meng.yi@nxp.com --- Changes in V2: -drop the unit address of port --- Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt b/Documentation/devicetree/bindings/display/fsl,dcu.txt index ae55cde..c96ec1f 100644 --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt @@ -12,7 +12,7 @@ Required properties: - clock-names: Should be "dcu" and "pix" See ../clocks/clock-bindings.txt for details. - big-endian Boolean property, LS1021A DCU registers are big-endian. -- fsl,panel: The phandle to panel node. +- port Video port for the panel output
Optional properties: - fsl,tcon: The phandle to the timing controller node. @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 { clocks = <&platform_clk 0>, <&platform_clk 0>; clock-names = "dcu", "pix"; big-endian; - fsl,panel = <&panel>; fsl,tcon = <&tcon>; + + port: port { + dcu_out: endpoint { + remote-endpoint = <&panel_out>; + }; + }; };
add of_graph dt binding for panel, and "fsl,panel" property is deprecated
Signed-off-by: Meng Yi meng.yi@nxp.com --- Changes in V2: -dropp the unit address of port --- arch/arm/boot/dts/ls1021a-twr.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts index 75ecaed..cbd92c8 100644 --- a/arch/arm/boot/dts/ls1021a-twr.dts +++ b/arch/arm/boot/dts/ls1021a-twr.dts @@ -108,12 +108,22 @@
panel: panel { compatible = "nec,nl4827hc19-05b"; + port { + panel_out: endpoint { + remote-endpoint = <&dcu_out>; + }; + }; }; };
&dcu { - fsl,panel = <&panel>; status = "okay"; + + port: port { + dcu_out: endpoint { + remote-endpoint = <&panel_out>; + }; + }; };
&dspi1 {
On 2016-06-29 01:17, Meng Yi wrote:
add of_graph dt binding for panel, and "fsl,panel" property
Nit: "binding" typically describes the requirement, the specification and hence is under Documentation/devicetree/bindings/.
What you add here is the dt nodes according to the bindings...
Hence I would say something like
Add of_graph dt nodes to describe the panel and remove the "fsl,panel" property.
is deprecated
Signed-off-by: Meng Yi meng.yi@nxp.com
Changes in V2:
-dropp the unit address of port
arch/arm/boot/dts/ls1021a-twr.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts index 75ecaed..cbd92c8 100644 --- a/arch/arm/boot/dts/ls1021a-twr.dts +++ b/arch/arm/boot/dts/ls1021a-twr.dts @@ -108,12 +108,22 @@
panel: panel { compatible = "nec,nl4827hc19-05b";
Nit: We typically add a new line before adding a subnode.
port {panel_out: endpoint {remote-endpoint = <&dcu_out>;};};};
&dcu {
- fsl,panel = <&panel>; status = "okay";
- port: port {
Same as in bindings, port does not need a label too.
dcu_out: endpoint {remote-endpoint = <&panel_out>;};- };
};
&dspi1 {
There is still a patch for vf-colibri-eval-v3.dtsi missing which does the same.
-- Stefan
On Wed, Jun 29, 2016 at 04:17:57PM +0800, Meng Yi wrote:
dropped the old "fsl,panel" property, using the of_graph dt binding syntax
Signed-off-by: Meng Yi meng.yi@nxp.com
Changes in V2:
-drop the unit address of port
Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Acked-by: Rob Herring robh@kernel.org
On 2016-06-29 01:17, Meng Yi wrote:
dropped the old "fsl,panel" property, using the of_graph dt binding syntax
Signed-off-by: Meng Yi meng.yi@nxp.com
Changes in V2:
-drop the unit address of port
Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt b/Documentation/devicetree/bindings/display/fsl,dcu.txt index ae55cde..c96ec1f 100644 --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt @@ -12,7 +12,7 @@ Required properties:
- clock-names: Should be "dcu" and "pix" See ../clocks/clock-bindings.txt for details.
- big-endian Boolean property, LS1021A DCU registers are big-endian.
-- fsl,panel: The phandle to panel node. +- port Video port for the panel output
Optional properties:
- fsl,tcon: The phandle to the timing controller node.
@@ -24,6 +24,11 @@ dcu: dcu@2ce0000 { clocks = <&platform_clk 0>, <&platform_clk 0>; clock-names = "dcu", "pix"; big-endian;
- fsl,panel = <&panel>; fsl,tcon = <&tcon>;
- port: port {
Port does not need a label here.
dcu_out: endpoint {remote-endpoint = <&panel_out>;};- };
};
Otherwise looks good. However, I would prefer to have this change as part of the corresponding driver change. Can you squash that into the "drm/fsl-dcu: rework codes to support of_graph dt binding for panel" patch?
-- Stefan
dri-devel@lists.freedesktop.org
-
Meng Yi -
Rob Herring -
Stefan Agner