On 3/22/22 21:33, Christophe JAILLET wrote:

of_parse_display_timing() already call memset(0) on its 2nd argument, so there is no need to clear it explicitly before calling this function.

Use kmalloc() instead of kzalloc() to save a few cycles.

Signed-off-by: Christophe JAILLET christophe.jaillet@wanadoo.fr

applied.

Thanks! Helge

---

drivers/video/of_display_timing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index f93b6abbe258..bebd371c6b93 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -199,7 +199,7 @@ struct display_timings *of_get_display_timings(const struct device_node *np) struct display_timing *dt; int r;

• dt = kzalloc(sizeof(*dt), GFP_KERNEL);
  

• dt = kmalloc(sizeof(*dt), GFP_KERNEL);
  

  if (!dt) { pr_err("%pOF: could not allocate display_timing struct\n", np);