Hi

On Thu, Sep 11, 2014 at 10:53 PM, Kees Cook keescook@chromium.org wrote:

While zone->name is currently hard coded, the call to kobject_init_and_add() should follow the more defensive argument list usage (as already done in other places in ttm_memory.c) where "%s" is used instead of directly passing in a variable as a format string.

Signed-off-by: Kees Cook keescook@chromium.org

Reviewed-by: David Herrmann dh.herrmann@gmail.com

Thanks David

---

drivers/gpu/drm/ttm/ttm_memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ttm/ttm_memory.c b/drivers/gpu/drm/ttm/ttm_memory.c index fa53df487875..1e688b603e46 100644 --- a/drivers/gpu/drm/ttm/ttm_memory.c +++ b/drivers/gpu/drm/ttm/ttm_memory.c @@ -300,7 +300,8 @@ static int ttm_mem_init_highmem_zone(struct ttm_mem_global *glob, zone->glob = glob; glob->zone_highmem = zone; ret = kobject_init_and_add(

•           &zone->kobj, &ttm_mem_zone_kobj_type, &glob->kobj, zone->name);
  

•           &zone->kobj, &ttm_mem_zone_kobj_type, &glob->kobj, "%s",
  

•           zone->name);
    if (unlikely(ret != 0)) {
            kobject_put(&zone->kobj);
            return ret;
  

-- 1.9.1

-- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/