2015-03-31 14:15 GMT-03:00 Todd Previte tprevite@gmail.com:

The debug message is missing a newline at the end and it makes the logs hard to read when a device defers a lot. Simple 2-character fix adds the newline at the end.

Signed-off-by: Todd Previte tprevite@gmail.com Cc: dri-devel@lists.freedesktop.org

Why in some logs there is in fact a newline, such as here: https://bugs.freedesktop.org/attachment.cgi?id=110049 ?

Anyway, it looks correct, so: Reviewed-by: Paulo Zanoni paulo.r.zanoni@intel.com

---

drivers/gpu/drm/drm_dp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 0539758..281bb67 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -433,7 +433,7 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) return -EREMOTEIO;

            case DP_AUX_NATIVE_REPLY_DEFER:

•                   DRM_DEBUG_KMS("native defer");
  

•                   DRM_DEBUG_KMS("native defer\n");
                    /*
                     * We could check for I2C bit rate capabilities and if
                     * available adjust this interval. We could also be
  

-- 1.9.1

---

Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx