From: Colin Ian King colin.king@canonical.com
The msg_id field is being assigned twice. Fix this by replacing the second assignment with an assignment to msg_size.
Addresses-Coverity: ("Unused value") Fixes: 11a00965d261 ("drm/amd/display: Add PSP block to verify HDCP2.2 steps") Signed-off-by: Colin Ian King colin.king@canonical.com --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c index 2dd5feec8e6c..6791c5844e43 100644 --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c @@ -42,7 +42,7 @@ static void hdcp2_message_init(struct mod_hdcp *hdcp, in->process.msg2_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE; in->process.msg2_desc.msg_size = 0; in->process.msg3_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE; - in->process.msg3_desc.msg_id = 0; + in->process.msg3_desc.msg_size = 0; } enum mod_hdcp_status mod_hdcp_remove_display_topology(struct mod_hdcp *hdcp) {
On 2019-11-20 12:22 p.m., Colin King wrote:
From: Colin Ian King colin.king@canonical.com
The msg_id field is being assigned twice. Fix this by replacing the second assignment with an assignment to msg_size.
Addresses-Coverity: ("Unused value") Fixes: 11a00965d261 ("drm/amd/display: Add PSP block to verify HDCP2.2 steps") Signed-off-by: Colin Ian King colin.king@canonical.com
Reviewed-by: Harry Wentland <harry.wentland>
Harry
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c index 2dd5feec8e6c..6791c5844e43 100644 --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c @@ -42,7 +42,7 @@ static void hdcp2_message_init(struct mod_hdcp *hdcp, in->process.msg2_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE; in->process.msg2_desc.msg_size = 0; in->process.msg3_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
- in->process.msg3_desc.msg_id = 0;
- in->process.msg3_desc.msg_size = 0;
} enum mod_hdcp_status mod_hdcp_remove_display_topology(struct mod_hdcp *hdcp) {
Applied. thanks!
Alex
On Wed, Nov 27, 2019 at 11:51 AM Harry Wentland hwentlan@amd.com wrote:
On 2019-11-20 12:22 p.m., Colin King wrote:
From: Colin Ian King colin.king@canonical.com
The msg_id field is being assigned twice. Fix this by replacing the second assignment with an assignment to msg_size.
Addresses-Coverity: ("Unused value") Fixes: 11a00965d261 ("drm/amd/display: Add PSP block to verify HDCP2.2 steps") Signed-off-by: Colin Ian King colin.king@canonical.com
Reviewed-by: Harry Wentland <harry.wentland>
Harry
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c index 2dd5feec8e6c..6791c5844e43 100644 --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c @@ -42,7 +42,7 @@ static void hdcp2_message_init(struct mod_hdcp *hdcp, in->process.msg2_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE; in->process.msg2_desc.msg_size = 0; in->process.msg3_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
in->process.msg3_desc.msg_id = 0;
in->process.msg3_desc.msg_size = 0;} enum mod_hdcp_status mod_hdcp_remove_display_topology(struct mod_hdcp *hdcp) {
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Colin King -
Harry Wentland