Reading the EDID of this panel shows that these flags should be set. Set them so that we match what is in the EDID.
Cc: Douglas Anderson dianders@chromium.org Cc: Bjorn Andersson bjorn.andersson@linaro.org Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61") Signed-off-by: Stephen Boyd swboyd@chromium.org --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 2be358fb46f7..204674fccd64 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1327,6 +1327,7 @@ static const struct drm_display_mode boe_nv133fhm_n61_modes = { .vsync_start = 1080 + 3, .vsync_end = 1080 + 3 + 6, .vtotal = 1080 + 3 + 6 + 31, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC, };
/* Also used for boe_nv133fhm_n62 */
base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
Hi,
On Fri, Nov 6, 2020 at 10:23 AM Stephen Boyd swboyd@chromium.org wrote:
Reading the EDID of this panel shows that these flags should be set. Set them so that we match what is in the EDID.
Cc: Douglas Anderson dianders@chromium.org Cc: Bjorn Andersson bjorn.andersson@linaro.org Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61") Signed-off-by: Stephen Boyd swboyd@chromium.org
drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+)
Yeah, generally I haven't found that the flags matter, but it's good to match what the EDID is giving to keep things consistent. :-)
Reviewed-by: Douglas Anderson dianders@chromium.org
Hi Stephen On Fri, Nov 06, 2020 at 10:23:33AM -0800, Stephen Boyd wrote:
Reading the EDID of this panel shows that these flags should be set. Set them so that we match what is in the EDID.
Cc: Douglas Anderson dianders@chromium.org Cc: Bjorn Andersson bjorn.andersson@linaro.org Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61") Signed-off-by: Stephen Boyd swboyd@chromium.org
Applied to drm-misc-next as I could not see this was needed in mainline. Or at least not urgently. Let me know if this should be expeditet to current -rc
Sam
dri-devel@lists.freedesktop.org