[radeon-alex:vega20_psp_smu 12/44] drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c:191:33: sparse: symbol 'nbio_v7_4_hdp_flush_reg' was not declared. Should it be static?
tree: git://people.freedesktop.org/~agd5f/linux.git vega20_psp_smu head: 9b9ef18df4349dd2d2b8941e76c032ed8acf2529 commit: 24048ee665f3c9367dfa4978f3cd9b4e428fe2e5 [12/44] drm/amdgpu: Add nbio 7.4 support for vega20 (v2) reproduce: # apt-get install sparse git checkout 24048ee665f3c9367dfa4978f3cd9b4e428fe2e5 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c:191:33: sparse: symbol 'nbio_v7_4_hdp_flush_reg' was not declared. Should it be static?
Please review and possibly fold the followup patch.
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Fixes: 24048ee665f3 ("drm/amdgpu: Add nbio 7.4 support for vega20 (v2)") Signed-off-by: kbuild test robot fengguang.wu@intel.com --- nbio_v7_4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c index 623ffde..89ea920 100644 --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c @@ -188,7 +188,7 @@ static u32 nbio_v7_4_get_pcie_data_offset(struct amdgpu_device *adev) return SOC15_REG_OFFSET(NBIO, 0, mmPCIE_DATA2); }
-const struct nbio_hdp_flush_reg nbio_v7_4_hdp_flush_reg = { +static const struct nbio_hdp_flush_reg nbio_v7_4_hdp_flush_reg = { .ref_and_mask_cp0 = GPU_HDP_FLUSH_DONE__CP0_MASK, .ref_and_mask_cp1 = GPU_HDP_FLUSH_DONE__CP1_MASK, .ref_and_mask_cp2 = GPU_HDP_FLUSH_DONE__CP2_MASK,
Applied. thanks!
Alex
________________________________ From: kbuild test robot fengguang.wu@intel.com Sent: Wednesday, August 15, 2018 12:45:08 AM To: Xu, Feifei Cc: kbuild-all@01.org; dri-devel@lists.freedesktop.org; Deucher, Alexander; Zhang, Hawking Subject: [RFC PATCH radeon-alex] drm/amdgpu: nbio_v7_4_hdp_flush_reg can be static
Fixes: 24048ee665f3 ("drm/amdgpu: Add nbio 7.4 support for vega20 (v2)") Signed-off-by: kbuild test robot fengguang.wu@intel.com --- nbio_v7_4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c index 623ffde..89ea920 100644 --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c @@ -188,7 +188,7 @@ static u32 nbio_v7_4_get_pcie_data_offset(struct amdgpu_device *adev) return SOC15_REG_OFFSET(NBIO, 0, mmPCIE_DATA2); }
-const struct nbio_hdp_flush_reg nbio_v7_4_hdp_flush_reg = { +static const struct nbio_hdp_flush_reg nbio_v7_4_hdp_flush_reg = { .ref_and_mask_cp0 = GPU_HDP_FLUSH_DONE__CP0_MASK, .ref_and_mask_cp1 = GPU_HDP_FLUSH_DONE__CP1_MASK, .ref_and_mask_cp2 = GPU_HDP_FLUSH_DONE__CP2_MASK,
dri-devel@lists.freedesktop.org
-
Deucher, Alexander -
kbuild test robot -
kbuild test robot