On Wed, Jun 9, 2010 at 10:17 AM, rscheidegger_lists@hispeed.ch wrote:

From: Roland Scheidegger sroland@vmware.com

using R100_TRACK_COMP_DXT1 instead of R100_TRACK_COMP_DXT35 for dxt3/5 textures leads to size calculations only half as big as they should be.

Signed-off-by: sroland@vmware.com

drivers/gpu/drm/radeon/r200.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/radeon/r200.c b/drivers/gpu/drm/radeon/r200.c index 85617c3..aac4b99 100644 --- a/drivers/gpu/drm/radeon/r200.c +++ b/drivers/gpu/drm/radeon/r200.c @@ -476,7 +476,7 @@ int r200_packet0_check(struct radeon_cs_parser *p,                case R200_TXFORMAT_DXT23:                case R200_TXFORMAT_DXT45:                        track->textures[i].cpp = 1;

• track->textures[i].compress_format = R100_TRACK_COMP_DXT1;

• track->textures[i].compress_format = R100_TRACK_COMP_DXT35;

break;                }                track->textures[i].cube_info[4].width = 1 << ((idx_value >> 16) & 0xf); -- 1.5.2.4

Blatant typo, as discussed on IRC. Very nice catch.

Reviewed-by: Corbin Simpson MostAwesomeDude@gmail.com

~ C.