On 31/12/2020 12:56, Xu Wang wrote:

Because clk_prepare_enable() and clk_disable_unprepare() already checked NULL clock parameter, so the additional checks are unnecessary, just remove them.

Signed-off-by: Xu Wang vulab@iscas.ac.cn

Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

---

drivers/gpu/drm/msm/dsi/dsi_host.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index ab281cba0f08..e7af90f045bf 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -565,13 +565,11 @@ int dsi_link_clk_enable_6g(struct msm_dsi_host *msm_host) goto pixel_clk_err; }

• if (msm_host->byte_intf_clk) {

• ret = clk_prepare_enable(msm_host->byte_intf_clk);
  

• if (ret) {
  

• 	pr_err("%s: Failed to enable byte intf clk\n",
  

• 	       __func__);
  

• 	goto byte_intf_clk_err;
  

• }
  

• ret = clk_prepare_enable(msm_host->byte_intf_clk);

• if (ret) {

• pr_err("%s: Failed to enable byte intf clk\n",
  

• 	   __func__);
  

• goto byte_intf_clk_err;
  

  }

  return 0;

@@ -667,8 +665,7 @@ void dsi_link_clk_disable_6g(struct msm_dsi_host *msm_host) dev_pm_opp_set_rate(&msm_host->pdev->dev, 0); clk_disable_unprepare(msm_host->esc_clk); clk_disable_unprepare(msm_host->pixel_clk);

• if (msm_host->byte_intf_clk)

• clk_disable_unprepare(msm_host->byte_intf_clk);
  

• clk_disable_unprepare(msm_host->byte_intf_clk); clk_disable_unprepare(msm_host->byte_clk); }