The eLCDIF controller is also present on i.MX6UL/i.MX6ULL SoCs so add them in the Kconfig option description.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com --- drivers/gpu/drm/mxsfb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig index 0143d539f8f8..a3730f52e6fa 100644 --- a/drivers/gpu/drm/mxsfb/Kconfig +++ b/drivers/gpu/drm/mxsfb/Kconfig @@ -17,6 +17,6 @@ config DRM_MXSFB help Choose this option if you have an LCDIF or eLCDIF LCD controller. Those devices are found in various i.MX SoC (including i.MX23, - i.MX28, i.MX6SX, i.MX7 and i.MX8M). + i.MX28, i.MX6UL/i.MX6ULL, i.MX6SX, i.MX7 and i.MX8M).
If M is selected the module will be called mxsfb.
The eLCDIF controller on i.MX6UL/i.MX6ULL supports the alpha plane too. Enable it on these SoCs.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com --- While testing, I have noticed that the alpha plane works but sometimes the framebuffer is shiftted to the right. I tested with the following modetest command:
modetest -M mxsfb-drm -s 37@35:800x480 -P 33@35:800x480@AR24 -F smpte,plain
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 6faf17b6408d..95c35333c2d1 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -306,6 +306,7 @@ static const struct drm_driver mxsfb_driver = { static const struct of_device_id mxsfb_dt_ids[] = { { .compatible = "fsl,imx23-lcdif", .data = &mxsfb_devdata[MXSFB_V3], }, { .compatible = "fsl,imx28-lcdif", .data = &mxsfb_devdata[MXSFB_V4], }, + { .compatible = "fsl,imx6ul-lcdif", .data = &mxsfb_devdata[MXSFB_V6], }, { .compatible = "fsl,imx6sx-lcdif", .data = &mxsfb_devdata[MXSFB_V6], }, { /* sentinel */ } };
i.MX6UL/i.MX6ULL have eLCDIF controller, too.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com --- Documentation/devicetree/bindings/display/mxsfb.txt | 1 + 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt index c985871c46b3..6c1c4ad04b89 100644 --- a/Documentation/devicetree/bindings/display/mxsfb.txt +++ b/Documentation/devicetree/bindings/display/mxsfb.txt @@ -5,6 +5,7 @@ New bindings: Required properties: - compatible: Should be "fsl,imx23-lcdif" for i.MX23. Should be "fsl,imx28-lcdif" for i.MX28. + Should be "fsl,imx6ul-lcdif" for i.MX6UL/i.MX6ULL. Should be "fsl,imx6sx-lcdif" for i.MX6SX. Should be "fsl,imx8mq-lcdif" for i.MX8MQ. - reg: Address and length of the register set for LCDIF
On Fri, Dec 18, 2020 at 03:10:35PM +0100, Sébastien Szymanski wrote:
i.MX6UL/i.MX6ULL have eLCDIF controller, too.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com
Documentation/devicetree/bindings/display/mxsfb.txt | 1 + 1 file changed, 1 insertion(+)
This will need to be rebased on this:
https://lore.kernel.org/dri-devel/20201007012438.27970-2-laurent.pinchart@id...
dri-devel@lists.freedesktop.org
-
Rob Herring -
Sébastien Szymanski