From: Antonio Borneo antonio.borneo@st.com
Current code only sends LP commands in command mode.
Allows sending LP commands also in video mode by setting the proper flag in DSI_VID_MODE_CFG.
Signed-off-by: Antonio Borneo antonio.borneo@st.com --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index d580b2aa4ce9..0cd43e7a69bb 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -367,6 +367,13 @@ static void dw_mipi_message_config(struct dw_mipi_dsi *dsi,
dsi_write(dsi, DSI_LPCLK_CTRL, lpm ? 0 : PHY_TXREQUESTCLKHS); dsi_write(dsi, DSI_CMD_MODE_CFG, val); + + val = dsi_read(dsi, DSI_VID_MODE_CFG); + if (lpm) + val |= ENABLE_LOW_POWER_CMD; + else + val &= ~ENABLE_LOW_POWER_CMD; + dsi_write(dsi, DSI_VID_MODE_CFG, val); }
static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val)
Hi Yannick,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc3 next-20200702] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yannick-Fertre/drm-bridge-synopsys-... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7c30b859a947535f2213277e827d7ac7dcff9c84 config: arm-randconfig-r013-20200701 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ca464639a1c9dd3944eb055ffd2796e8c2e7639f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:374:10: error: use of undeclared identifier 'ENABLE_LOW_POWER_CMD'
val |= ENABLE_LOW_POWER_CMD; ^ drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:376:11: error: use of undeclared identifier 'ENABLE_LOW_POWER_CMD' val &= ~ENABLE_LOW_POWER_CMD; ^ 2 errors generated.
vim +/ENABLE_LOW_POWER_CMD +374 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
357 358 static void dw_mipi_message_config(struct dw_mipi_dsi *dsi, 359 const struct mipi_dsi_msg *msg) 360 { 361 bool lpm = msg->flags & MIPI_DSI_MSG_USE_LPM; 362 u32 val = 0; 363 364 if (msg->flags & MIPI_DSI_MSG_REQ_ACK) 365 val |= ACK_RQST_EN; 366 if (lpm) 367 val |= CMD_MODE_ALL_LP; 368 369 dsi_write(dsi, DSI_LPCLK_CTRL, lpm ? 0 : PHY_TXREQUESTCLKHS); 370 dsi_write(dsi, DSI_CMD_MODE_CFG, val); 371 372 val = dsi_read(dsi, DSI_VID_MODE_CFG); 373 if (lpm)
374 val |= ENABLE_LOW_POWER_CMD;
375 else 376 val &= ~ENABLE_LOW_POWER_CMD; 377 dsi_write(dsi, DSI_VID_MODE_CFG, val); 378 } 379
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
dri-devel@lists.freedesktop.org
-
kernel test robot -
Yannick Fertre