https://bugzilla.kernel.org/show_bug.cgi?id=80331

Colin colin.bruce@ctalk.co.uk changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID

--- Comment #16 from Colin colin.bruce@ctalk.co.uk --- (In reply to Alex Deucher from comment #15)

(In reply to Colin from comment #14)

...

Thanks I'll give it a go when I home from work tonight. I am sure that will be the solution. Strange thing is that even with the firmware not loaded the card works fine when the patch is not present.

The patch changes when the firmware loads during driver init. With the patch the failure happens earlier so the error is fatal and the driver doesn't load. Without the patch, the driver still loads but all acceleration, interrupts, and most other features are disabled so it's not exactly working.

That explains it. I guess when it is a module it loads the firmware when the module loads and initializes. I had a look at the request_firmware() function and I think it will read the firmware if it is not already in memory. I suspect that can't work when it is static as the driver is initialized before the disk drivers are loaded. Anyway the so called "bug" turns out to be my stupidity:-( Such is life.

In any event thanks for all your help and the explanation.

Best wishes..... Colin

PS I'm not sure what the correct code from the list is. There isn't a "Stupid User" one so I picked Invalid. I hope that's ok.