if "CONFIG_DEV_COREDUMP=y" is added to configuration file, it gets removed when final configuration file is generated. The reason is it requires CONFIG_WANT_DEV_COREDUMP to be enabled.
Currently "make menuconfig" doesn't display an option to enable WANT_DEV_COREDUMP. This patch updates Kconfig so that user can enable WANT_DEV_COREDUMP.
Signed-off-by: Amitkumar Karwar akarwar@marvell.com Signed-off-by: Xinming Hu huxm@marvell.com Tested-by: Xinming Hu huxm@marvell.com --- drivers/base/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 61a33f4..e491b07 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -166,7 +166,7 @@ config FW_LOADER_USER_HELPER_FALLBACK If you are unsure about this, say N here.
config WANT_DEV_COREDUMP - bool + bool "Want device coredump" help Drivers should "select" this option if they desire to use the device coredump mechanism.
On Wed, 2014-11-19 at 05:28 -0800, Amitkumar Karwar wrote:
if "CONFIG_DEV_COREDUMP=y" is added to configuration file, it gets removed when final configuration file is generated. The reason is it requires CONFIG_WANT_DEV_COREDUMP to be enabled.
Currently "make menuconfig" doesn't display an option to enable WANT_DEV_COREDUMP. This patch updates Kconfig so that user can enable WANT_DEV_COREDUMP.
This is completely intentional - drivers should "select WANT_DEV_COREDUMP" and users are only able to set "ALLOW_DEV_COREDUMP=n" to prevent it.
johannes
Hi Johannes,
Currently "make menuconfig" doesn't display an option to enable WANT_DEV_COREDUMP. This patch updates Kconfig so that user can enable WANT_DEV_COREDUMP.
This is completely intentional - drivers should "select WANT_DEV_COREDUMP" and users are only able to set "ALLOW_DEV_COREDUMP=n" to prevent it.
Thanks for the clarification. We will modify our btmrvl driver patch accordingly then.
Regards, Amitkumar
dri-devel@lists.freedesktop.org
-
Amitkumar Karwar -
Johannes Berg