Hi!

Dne petek, 27. avgust 2021 ob 15:16:03 CEST je Roman Stratiienko napisal(a):

+CC: jernej.skrabec@gmail.com

пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko r.stratiienko@gmail.com:

...

Hello Jernej,

During local testing I faced an issue where YV12 buffers are displayed all in blue.

Issue can be fixed by reverting: ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")

Could you have a look please?

I believe I found the issue. Can you try replacing this line: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/sun4i/ sun8i_csc.h#L20

with: #define SUN8I_CSC_COEFF(base, i) (base + 0x10 + 4 * (i))

Note that "i" is in parenthesis.

Best regards, Jernej

...

Best regards, Roman Stratiienko

Dne torek, 31. avgust 2021 ob 19:18:42 CEST je Roman Stratiienko napisal(a):

Hi Jernej,

вт, 31 авг. 2021 г. в 19:52, Jernej Škrabec jernej.skrabec@gmail.com:

...

Hi!

Dne petek, 27. avgust 2021 ob 15:16:03 CEST je Roman Stratiienko

napisal(a):

...

...

+CC: jernej.skrabec@gmail.com

пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko

r.stratiienko@gmail.com:

...

...

...

Hello Jernej,

During local testing I faced an issue where YV12 buffers are displayed all in blue.

Issue can be fixed by reverting: ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")

Could you have a look please?

I believe I found the issue. Can you try replacing this line: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/sun4i/ sun8i_csc.h#L20

with: #define SUN8I_CSC_COEFF(base, i) (base + 0x10 + 4 * (i))

Note that "i" is in parenthesis.

Thank you for your quick response. Yeah, that's it. Adding parenthesis solves the issue.

Thanks for reporting & testing!

Best regards, Jernej

...

Best regards, Jernej

...

...

Best regards, Roman Stratiienko