*** BLURB HERE ***
David Zhang (1): drm: add PSR2 support and capability definition as per eDP 1.5
include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)
[why & how] In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU support.
Signed-off-by: David Zhang dingchen.zhang@amd.com --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 30359e434c3f..ac7b7571ae66 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -361,6 +361,7 @@ struct drm_panel; # define DP_PSR_IS_SUPPORTED 1 # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */ # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED 3 /* eDP 1.4a */ +# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 4 /* eDP 1.5, adopted eDP 1.4b SCR */
#define DP_PSR_CAPS 0x071 /* XXX 1.2? */ # define DP_PSR_NO_TRAIN_ON_EXIT 1 @@ -375,6 +376,7 @@ struct drm_panel; # define DP_PSR_SETUP_TIME_SHIFT 1 # define DP_PSR2_SU_Y_COORDINATE_REQUIRED (1 << 4) /* eDP 1.4a */ # define DP_PSR2_SU_GRANULARITY_REQUIRED (1 << 5) /* eDP 1.4b */ +# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */
#define DP_PSR2_SU_X_GRANULARITY 0x072 /* eDP 1.4b */ #define DP_PSR2_SU_Y_GRANULARITY 0x074 /* eDP 1.4b */
On 2022-03-31 13:26, David Zhang wrote:
[why & how] In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU
Please fix up the type in "fileds"
support.
Signed-off-by: David Zhang dingchen.zhang@amd.com
With that fixed this patch is Reviewed-by: Harry Wentland harry.wentland@amd.com
Btw, you don't need to add a cover letter for a single patch. The patch alone is fine.
Harry
include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 30359e434c3f..ac7b7571ae66 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -361,6 +361,7 @@ struct drm_panel; # define DP_PSR_IS_SUPPORTED 1 # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */ # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED 3 /* eDP 1.4a */ +# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 4 /* eDP 1.5, adopted eDP 1.4b SCR */
#define DP_PSR_CAPS 0x071 /* XXX 1.2? */ # define DP_PSR_NO_TRAIN_ON_EXIT 1 @@ -375,6 +376,7 @@ struct drm_panel; # define DP_PSR_SETUP_TIME_SHIFT 1 # define DP_PSR2_SU_Y_COORDINATE_REQUIRED (1 << 4) /* eDP 1.4a */ # define DP_PSR2_SU_GRANULARITY_REQUIRED (1 << 5) /* eDP 1.4b */ +# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */
#define DP_PSR2_SU_X_GRANULARITY 0x072 /* eDP 1.4b */ #define DP_PSR2_SU_Y_GRANULARITY 0x074 /* eDP 1.4b */
Dear David,
Thank you for your patch.
Am 31.03.22 um 19:26 schrieb David Zhang:
[why & how] In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU support.
You could be specific by using the exact number two. Maybe:
As per eDP 1.5 specification, add the two DPCD bit fields below for PSR-SU support:
1. DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 2. DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED
Kind regards,
Paul
Signed-off-by: David Zhang dingchen.zhang@amd.com
include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 30359e434c3f..ac7b7571ae66 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -361,6 +361,7 @@ struct drm_panel; # define DP_PSR_IS_SUPPORTED 1 # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */ # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED 3 /* eDP 1.4a */ +# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 4 /* eDP 1.5, adopted eDP 1.4b SCR */
#define DP_PSR_CAPS 0x071 /* XXX 1.2? */ # define DP_PSR_NO_TRAIN_ON_EXIT 1 @@ -375,6 +376,7 @@ struct drm_panel; # define DP_PSR_SETUP_TIME_SHIFT 1 # define DP_PSR2_SU_Y_COORDINATE_REQUIRED (1 << 4) /* eDP 1.4a */ # define DP_PSR2_SU_GRANULARITY_REQUIRED (1 << 5) /* eDP 1.4b */ +# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */
#define DP_PSR2_SU_X_GRANULARITY 0x072 /* eDP 1.4b */ #define DP_PSR2_SU_Y_GRANULARITY 0x074 /* eDP 1.4b */
[AMD Official Use Only]
Hi Paul and Harry,
Thanks for reviewing the patch and commit msg has been revised as per your comments in the v2.
From: Paul Menzel pmenzel@molgen.mpg.de Sent: Friday, April 1, 2022 1:46 AM To: Zhang, Dingchen (David) Dingchen.Zhang@amd.com Cc: amd-gfx@lists.freedesktop.org amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org dri-devel@lists.freedesktop.org; Wang, Chao-kai (Stylon) Stylon.Wang@amd.com; airlied@linux.ie airlied@linux.ie; Li, Sun peng (Leo) Sunpeng.Li@amd.com; Wentland, Harry Harry.Wentland@amd.com; Zhuo, Qingqing (Lillian) Qingqing.Zhuo@amd.com; Siqueira, Rodrigo Rodrigo.Siqueira@amd.com; Li, Roman Roman.Li@amd.com; Chiu, Solomon Solomon.Chiu@amd.com; Zuo, Jerry Jerry.Zuo@amd.com; Pillai, Aurabindo Aurabindo.Pillai@amd.com; daniel@ffwll.ch daniel@ffwll.ch; Lin, Wayne Wayne.Lin@amd.com; Lakha, Bhawanpreet Bhawanpreet.Lakha@amd.com; Gutierrez, Agustin Agustin.Gutierrez@amd.com; Kotarac, Pavle Pavle.Kotarac@amd.com Subject: Re: [PATCH 1/1] drm: add PSR2 support and capability definition as per eDP 1.5
Dear David,
Thank you for your patch.
Am 31.03.22 um 19:26 schrieb David Zhang:
[why & how] In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU support.
You could be specific by using the exact number two. Maybe:
As per eDP 1.5 specification, add the two DPCD bit fields below for PSR-SU support:
1. DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 2. DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED
Kind regards,
Paul
Signed-off-by: David Zhang dingchen.zhang@amd.com
include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 30359e434c3f..ac7b7571ae66 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -361,6 +361,7 @@ struct drm_panel; # define DP_PSR_IS_SUPPORTED 1 # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */ # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED 3 /* eDP 1.4a */ +# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 4 /* eDP 1.5, adopted eDP 1.4b SCR */
#define DP_PSR_CAPS 0x071 /* XXX 1.2? */ # define DP_PSR_NO_TRAIN_ON_EXIT 1 @@ -375,6 +376,7 @@ struct drm_panel; # define DP_PSR_SETUP_TIME_SHIFT 1 # define DP_PSR2_SU_Y_COORDINATE_REQUIRED (1 << 4) /* eDP 1.4a */ # define DP_PSR2_SU_GRANULARITY_REQUIRED (1 << 5) /* eDP 1.4b */ +# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */
#define DP_PSR2_SU_X_GRANULARITY 0x072 /* eDP 1.4b */ #define DP_PSR2_SU_Y_GRANULARITY 0x074 /* eDP 1.4b */
dri-devel@lists.freedesktop.org
-
David Zhang -
Harry Wentland -
Paul Menzel -
Zhang, Dingchen (David)