Hi all,
On Fri, 23 Aug 2019 17:00:39 -0700 (PDT) "kernelci.org bot" bot@kernelci.org wrote:
2 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function 'dma_set_max_seg_size'; did you mean 'drm_rect_adjust_size'? [-Werror=implicit-function-declaration] 2 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function 'DMA_BIT_MASK'; did you mean 'BIT_MASK'? [-Werror=implicit-function-declaration] 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function 'dma_set_max_seg_size' [-Werror,-Wimplicit-function-declaration] 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function 'DMA_BIT_MASK' [-Werror,-Wimplicit-function-declaration]
Caused by commit
070955558e82 ("drm/mediatek: set DMA max segment size")
(from the drm-fixes tree) which should have included linux/dma-mapping.h
On Sat, 24 Aug 2019 at 13:53, Stephen Rothwell sfr@canb.auug.org.au wrote:
Hi all,
On Fri, 23 Aug 2019 17:00:39 -0700 (PDT) "kernelci.org bot" bot@kernelci.org wrote:
2 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function 'dma_set_max_seg_size'; did you mean 'drm_rect_adjust_size'? [-Werror=implicit-function-declaration] 2 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function 'DMA_BIT_MASK'; did you mean 'BIT_MASK'? [-Werror=implicit-function-declaration] 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function 'dma_set_max_seg_size' [-Werror,-Wimplicit-function-declaration] 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 1 drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function 'DMA_BIT_MASK' [-Werror,-Wimplicit-function-declaration]
Caused by commit
070955558e82 ("drm/mediatek: set DMA max segment size")
(from the drm-fixes tree) which should have included linux/dma-mapping.h
must be some Kconfig cases, it builds here fine (in -fixes at least).
Maybe something in next whacked the include file.
I'll add the include anyways and send to Linus,
Dave.
-- Cheers, Stephen Rothwell _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Dave,
On Sat, 24 Aug 2019 15:06:07 +1000 Dave Airlie airlied@gmail.com wrote:
I'll add the include anyways and send to Linus,
Thanks.
dri-devel@lists.freedesktop.org