The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default implementations for functions in struct fb_ops. A drm driver can use it like:

static struct fb_ops drm_fbdev_cma_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, /* driver specific implementations */ };

Suggested-by: Daniel Vetter daniel@ffwll.ch Signed-off-by: Stefan Christ contact@stefanchrist.eu --- v2: Fix sphinx error: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS: --- include/drm/drm_fb_helper.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index db8d478..f7d7126 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -214,6 +214,19 @@ struct drm_fb_helper { bool delayed_hotplug; };

+/** + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers + * + * Helper define to register default implementations of drm_fb_helper + * functions. To be used in struct fb_ops of drm drivers. + */ +#define DRM_FB_HELPER_DEFAULT_OPS \ + .fb_check_var = drm_fb_helper_check_var, \ + .fb_set_par = drm_fb_helper_set_par, \ + .fb_setcmap = drm_fb_helper_setcmap, \ + .fb_blank = drm_fb_helper_blank, \ + .fb_pan_display = drm_fb_helper_pan_display + #ifdef CONFIG_DRM_FBDEV_EMULATION int drm_fb_helper_modinit(void); void drm_fb_helper_prepare(struct drm_device *dev, struct drm_fb_helper *helper,

On Wed, Oct 05, 2016 at 11:00:03AM +0200, Gustavo Padovan wrote:

Hi Stefan,

2016-10-04 Stefan Christ contact@stefanchrist.eu:

...

The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default implementations for functions in struct fb_ops. A drm driver can use it like:

static struct fb_ops drm_fbdev_cma_ops = {
    .owner          = THIS_MODULE,
    DRM_FB_HELPER_DEFAULT_OPS,
    /* driver specific implementations */
};

Suggested-by: Daniel Vetter daniel@ffwll.ch Signed-off-by: Stefan Christ contact@stefanchrist.eu

---

v2: Fix sphinx error: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:

---

include/drm/drm_fb_helper.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index db8d478..f7d7126 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -214,6 +214,19 @@ struct drm_fb_helper { bool delayed_hotplug; };

+/**

• • define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers

If I'm not mistaken v1 of this patch is already in drm-misc so you may want to send a patch that fix just the line above.

Yup, I need an incremental patch which applies on top of drm-misc or linux-next. Sorry if this wasn't clear. -Daniel

On Wed, Oct 05, 2016 at 08:34:14PM +0200, Stefan Christ wrote:

Fix invalid sphinx markup in the comment for the newly added DRM_FB_HELPER_DEFAULT_OPS.

Signed-off-by: Stefan Christ contact@stefanchrist.eu

Hi,

...

...

If I'm not mistaken v1 of this patch is already in drm-misc so you may want to send a patch that fix just the line above.

Yup, I need an incremental patch which applies on top of drm-misc or linux-next. Sorry if this wasn't clear. -Daniel

Thanks for the head-ups. Here is a fix patch for it. Actually I should have come up with the same idea myself seeing the patch queued for the next pull request.

I have not added a "Fixes:" trailer in the commit message. If this is necessary I can resend it, when I see the offending patch in Linus master tree with a commit id.

drm-misc has stable sha1, which means you can cite them already when they show up in linux-next. But for a minor fix like this no big deal really.

Applied to drm-misc, thanks. -Daniel

Kind regards, Stefan Christ

---

include/drm/drm_fb_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 3c5f599..ed8edfe 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -218,7 +218,7 @@ struct drm_fb_helper { };

/**

• • @DRM_FB_HELPER_DEFAULT_OPS:

• • define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
  • Helper define to register default implementations of drm_fb_helper
  • functions. To be used in struct fb_ops of drm drivers.

-- 2.1.4