https://bugs.freedesktop.org/show_bug.cgi?id=93217
Bug ID: 93217 Summary: [tonga] [powerplay] Radon M395X isn't initialised with the powerplay branch Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel@lists.freedesktop.org Reporter: mike@fireburn.co.uk
Created attachment 120284 --> https://bugs.freedesktop.org/attachment.cgi?id=120284&action=edit dmesg powerplay
The card doesn't initialise:
amdgpu 0000:01:00.0: Fatal error during GPU init [TTM] Memory type 2 has not been initialized amdgpu: probe of 0000:01:00.0 failed with error -1
This is a hybrid system with skylake
I'll attach the dmesg with the powerplay branch and linus's tree
This is with runpm=0
00:00.0 Host bridge [0600]: Intel Corporation Sky Lake Host Bridge/DRAM Registers [8086:1910] (rev 07) 00:01.0 PCI bridge [0604]: Intel Corporation Sky Lake PCIe Controller (x16) [8086:1901] (rev 07) 00:02.0 VGA compatible controller [0300]: Intel Corporation Device [8086:191b] (rev 06) 00:04.0 Signal processing controller [1180]: Intel Corporation Device [8086:1903] (rev 07) 00:14.0 USB controller [0c03]: Intel Corporation Sunrise Point-H USB 3.0 xHCI Controller [8086:a12f] (rev 31) 00:14.2 Signal processing controller [1180]: Intel Corporation Sunrise Point-H Thermal subsystem [8086:a131] (rev 31) 00:16.0 Communication controller [0780]: Intel Corporation Sunrise Point-H CSME HECI #1 [8086:a13a] (rev 31) 00:17.0 SATA controller [0106]: Intel Corporation Sunrise Point-H SATA Controller [AHCI mode] [8086:a103] (rev 31) 00:1c.0 PCI bridge [0604]: Intel Corporation Sunrise Point-H PCI Express Root Port #1 [8086:a110] (rev f1) 00:1c.4 PCI bridge [0604]: Intel Corporation Sunrise Point-H PCI Express Root Port #5 [8086:a114] (rev f1) 00:1c.5 PCI bridge [0604]: Intel Corporation Sunrise Point-H PCI Express Root Port #6 [8086:a115] (rev f1) 00:1c.6 PCI bridge [0604]: Intel Corporation Sunrise Point-H PCI Express Root Port #7 [8086:a116] (rev f1) 00:1d.0 PCI bridge [0604]: Intel Corporation Sunrise Point-H PCI Express Root Port #9 [8086:a118] (rev f1) 00:1f.0 ISA bridge [0601]: Intel Corporation Sunrise Point-H LPC Controller [8086:a14e] (rev 31) 00:1f.2 Memory controller [0580]: Intel Corporation Sunrise Point-H PMC [8086:a121] (rev 31) 00:1f.3 Audio device [0403]: Intel Corporation Sunrise Point-H HD Audio [8086:a170] (rev 31) 00:1f.4 SMBus [0c05]: Intel Corporation Sunrise Point-H SMBus [8086:a123] (rev 31) 01:00.0 Display controller [0380]: Advanced Micro Devices, Inc. [AMD/ATI] Amethyst XT [Radeon R9 M295X] [1002:6921] 3b:00.0 Ethernet controller [0200]: Qualcomm Atheros Device [1969:e0a1] (rev 10) 3c:00.0 Network controller [0280]: Qualcomm Atheros QCA6174 802.11ac Wireless Network Adapter [168c:003e] (rev 32) 3d:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd. RTS5227 PCI Express Card Reader [10ec:5227] (rev 01) 3e:00.0 Non-Volatile memory controller [0108]: Samsung Electronics Co Ltd Device [144d:a802] (rev 01)
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mike@fireburn.co.uk
--- Comment #1 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120285 --> https://bugs.freedesktop.org/attachment.cgi?id=120285&action=edit dmesg tip
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #2 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120286 --> https://bugs.freedesktop.org/attachment.cgi?id=120286&action=edit xorg.log tip
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #3 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120287 --> https://bugs.freedesktop.org/attachment.cgi?id=120287&action=edit xorg.log powerplay
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #4 from Mike Lothian mike@fireburn.co.uk --- I'd just like to add that booting with amdgpu.powerplay=0 allow the card to be initialized
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #120284|0 |1 is obsolete| |
--- Comment #5 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120392 --> https://bugs.freedesktop.org/attachment.cgi?id=120392&action=edit Updated dmesg with drm.debug=0xf
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Hardware|Other |x86-64 (AMD64) OS|All |Linux (All)
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #6 from Alex Deucher alexdeucher@gmail.com --- Created attachment 120397 --> https://bugs.freedesktop.org/attachment.cgi?id=120397&action=edit add debugging output
Please apply this patch and attach the output.
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #120392|0 |1 is obsolete| |
--- Comment #7 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120399 --> https://bugs.freedesktop.org/attachment.cgi?id=120399&action=edit Dmesg with patch applied
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #8 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120464 --> https://bugs.freedesktop.org/attachment.cgi?id=120464&action=edit Ooops on shutdown
This is what's produced on shutdown on Linus's tree (0bd0f1e6d40aa16c4d507b1fff27163a7e7711f5) I'm not sure if it's related
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #9 from Alex Deucher alexdeucher@gmail.com --- Please try the latest powerplay branch and attach the dmesg log. It will print some additional debugging info for the failures.
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #120399|0 |1 is obsolete| |
--- Comment #10 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120466 --> https://bugs.freedesktop.org/attachment.cgi?id=120466&action=edit Dmesg with rebased powerplay branch
Seems "init_thermal_controller failed" is the problem
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #11 from Alex Deucher alexdeucher@gmail.com --- See if the latest patches in my powerplay branch helps.
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #120466|0 |1 is obsolete| |
--- Comment #12 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120501 --> https://bugs.freedesktop.org/attachment.cgi?id=120501&action=edit Dmesg ignoring table
This is strange - it looks as though initialisation gets a lot further but then stops when it "Failed to send Previous Message" and "unforce pcie level failed!"
The loading of the kernel felt longer than before and after 30 seconds the whole machine locked up
I managed to save this dmesg just in time after several attempts
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #13 from Alex Deucher alexdeucher@gmail.com --- Created attachment 120503 --> https://bugs.freedesktop.org/attachment.cgi?id=120503&action=edit disable pcie dpm
Does this allow it to start?
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #14 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120504 --> https://bugs.freedesktop.org/attachment.cgi?id=120504&action=edit Divide error
It was still doing the slow booting thing and freezing just after the disks mount and before X starts, I don't get the "Last Message" messages anymore, I tried doing this a few times and got the above divide error
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #15 from Alex Deucher alexdeucher@gmail.com --- Try my updated powerplay branch both with and without the disable_pcie_dpm patch.
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #120285|0 |1 is obsolete| | Attachment #120501|0 |1 is obsolete| |
--- Comment #16 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120507 --> https://bugs.freedesktop.org/attachment.cgi?id=120507&action=edit Powerplay working
I still have to set pcie_dpm_key_disabled = 1
I had to turn of pid cgroups for some reason
I also had to turn off runpm, it seems the card is initialised the first time then when it's powered back up has a hissy fit
I tested Metro 2033 Redux so I know I was definitely running on Tonga but I locked up the system setting everything to max
Progress :D
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #17 from Mike Lothian mike@fireburn.co.uk --- The card is also reported my lm_sensors - someone asked about this on IRC the other day
amdgpu-pci-0100 Adapter: PCI adapter temp1: +59.0°C (crit = +0.0°C, hyst = +0.0°C)
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #18 from Mike Lothian mike@fireburn.co.uk --- Created attachment 120589 --> https://bugs.freedesktop.org/attachment.cgi?id=120589&action=edit Screenshot of divide by zero error
I've just retried your latest powerplay branch
I still have to set pcie_dpm_key_disabled = 1 to prevent the message errors
I however how get another divide by zero issue and the kernel doesn't start
I'm attaching a screenshot
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #120589|text/plain |image/jpeg mime type| |
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #19 from Mike Lothian mike@fireburn.co.uk --- The commit "amd/powerplay: don't enable ucode fan control if vbios has no fan table" allows my machine to boot again - thanks
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #20 from Alex Deucher alexdeucher@gmail.com --- Created attachment 120644 --> https://bugs.freedesktop.org/attachment.cgi?id=120644&action=edit disable pcie gen3 switching
Does this patch allow you to use pcie dpm?
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #21 from Mike Lothian mike@fireburn.co.uk --- Nope, I still get the "message" errors
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #22 from Mike Lothian mike@fireburn.co.uk --- On both drm next and linus's tree with powerplay enabled and pcie dpm disabled runpm appears to be working however the performance doesn't seem as good as before
I'm not convinced powerplay is enabled
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #120507|0 |1 is obsolete| |
--- Comment #23 from Mike Lothian mike@fireburn.co.uk --- Created attachment 121181 --> https://bugs.freedesktop.org/attachment.cgi?id=121181&action=edit Latest dmesg
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #24 from Alex Deucher alexdeucher@gmail.com --- Powerplay is still disabled by default in drm-next and linus tree. Enable it by passing amdgpu.powerplay=1 on the kernel command line in grub.
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #25 from Mike Lothian mike@fireburn.co.uk --- As you can see from the dmesg - I've enabled it
It seems to be a runpm problem, with amdgpu.runpm=1 the chip now reinitialises when DRI_PRIME=1 is passed but it seems the speeds don't ramp up and there's a warning about themal values. With amdgpu.runpm=0 everything still seems to work but of course the card doesn't switch off when not in use
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #26 from Joshua clark@medstore.ml --- http://url.dsl.pp.ua/875575/pils/page.php
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #27 from Mike Lothian mike@fireburn.co.uk --- I've tried your latest 4.6-wip branch, I still have to disable pcie_dpm to get the kernel to boot, and I have to disable runpm to get performance
Let me know if you'd like me to test any of the new sysfs knobs you've added
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #28 from Mike Lothian mike@fireburn.co.uk --- 0: 2.5GB, x8 1: 8.0GB, x16 * 2: 8.0GB, x16 3: 8.0GB, x16 4: 8.0GB, x16 5: 8.0GB, x16 6: 8.0GB, x16 ./devices/pci0000:00/0000:00:01.0/0000:01:00.0/pp_dpm_pcie (END)
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #29 from Mike Lothian mike@fireburn.co.uk --- Would you like me to try re-enabling pcie dpm and use the new kernel parameters in drm-next-4.6-wip?
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #30 from Alex Deucher alexdeucher@gmail.com --- (In reply to Mike Lothian from comment #29)
Would you like me to try re-enabling pcie dpm and use the new kernel parameters in drm-next-4.6-wip?
Yes, can you see what combinations of pcie_gen_cap and pcie_lane_cap help? See amd_pcie.h.
pcie_gen_cap: bits 31:16 define the gen speeds supported by the platform (e.g., the motherboard). Setting it to CAIL_PCIE_LINK_SPEED_SUPPORT_GEN3 (0x00040000) would indicate that the motherboard only supports gen3 (not gen 2 or 1). bits 15:0 define the pcie speeds supported by the GPU itself. Setting this to CAIL_ASIC_PCIE_LINK_SPEED_SUPPORT_GEN3 (0x00000004) means the asic only supports gen 3.
pcie_lane_cap: bits 31:16 define the link width supported by the platform.
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #31 from Mike Lothian mike@fireburn.co.uk --- Sorry I'm a wee bit confused at what you'd like me to do
https://bugs.freedesktop.org/show_bug.cgi?id=93217
Mike Lothian mike@fireburn.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #32 from Mike Lothian mike@fireburn.co.uk --- I've just tried booting without using the PCIe DPM patch and it now seems to work
Not sure if it was a commit or the new firmware - either way this works for me now
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #33 from Alex Deucher alexdeucher@gmail.com --- What model laptop is this?
https://bugs.freedesktop.org/show_bug.cgi?id=93217
--- Comment #34 from Mike Lothian mike@fireburn.co.uk --- Alienware 15 R2
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org