On Sun, 13 Nov 2011 22:08:41 +0100, Christian Schmidt schmidt@digadd.de wrote:

My EFI BIOS starts the graphics card up in my projector's preferred EDID mode, 1080@60i. The Intel driver does not clear the interlaced bit:

#define PIPECONF_PROGRESSIVE (0 << 21) #define PIPECONF_INTERLACE_W_FIELD_INDICATION (6 << 21) #define PIPECONF_INTERLACE_FIELD_0_ONLY (7 << 21)

Likewise, I suppose that this bit is not set for interlaced modes either, however interlaced modes are discarded anyway.

The patch is correct, we do need to clear all 3 bits to restore progressive mode. However it would be better to add a new #define PIPECONF_INTERLACE_MASK (7 << 21) so that we do not confuse clearing all interlace bits with unsetting a particular mode. -Chris