https://bugs.freedesktop.org/show_bug.cgi?id=32326
Summary: [R200] DRM version check only looks at minor number. Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r200 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: rankincj@googlemail.com
Created an attachment (id=41021) View: https://bugs.freedesktop.org/attachment.cgi?id=41021 Review: https://bugs.freedesktop.org/review?bug=32326&attachment=41021
[PATCH] Enable microtiling for R200 if DRM >= v2.x
Mesa only checks the minor DRM version number when deciding whether to enable texture microtiling. This would imply that microtiling hasn't been enabled since the 2.6.30 kernel.
The HyperZ check for R200 does examine that the major DRM version number, but completely disables HyperZ for DRM v2.x. I don't know if this is intentional or not.
https://bugs.freedesktop.org/show_bug.cgi?id=32326
--- Comment #1 from Chris Rankin rankincj@googlemail.com 2010-12-11 14:54:08 PST --- There is a similar absence of DRM major version number checking in the radeonCreateScreen() funtion in radeon_screen.c
https://bugs.freedesktop.org/show_bug.cgi?id=32326
Dave Airlie airlied@freedesktop.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |NOTABUG
--- Comment #2 from Dave Airlie airlied@freedesktop.org 2010-12-11 15:33:59 PST --- This is correct, v2.x is a whole new interface that needs support to be added for these features.
Having v2 doesn't imply all the v1.x features since the whole kernel interface changed.
https://bugs.freedesktop.org/show_bug.cgi?id=32326
Chris Rankin rankincj@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|NOTABUG |
--- Comment #3 from Chris Rankin rankincj@googlemail.com 2010-12-11 15:38:10 PST --- (In reply to comment #2)
Having v2 doesn't imply all the v1.x features since the whole kernel interface changed.
Then the current code is NOT correct, because it should examine the DRM major version number and insist that it equals 1 instead.
https://bugs.freedesktop.org/show_bug.cgi?id=32326
--- Comment #4 from Dave Airlie airlied@freedesktop.org 2010-12-11 20:23:28 PST --- radeonCreatescreen is only called in DRI1 system,
radeonCreateScreen2 is called on DRI2 systems.
You can only have a version 1.x driver with a DRI1 system and a version 2.x driver with a DRI2 system.
Short of hacking things to force some wierd codepaths you can't cross the streams.
https://bugs.freedesktop.org/show_bug.cgi?id=32326
Chris Rankin rankincj@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #41021|0 |1 is obsolete| |
--- Comment #5 from Chris Rankin rankincj@googlemail.com 2010-12-12 06:10:22 PST --- Created an attachment (id=41039) View: https://bugs.freedesktop.org/attachment.cgi?id=41039 Review: https://bugs.freedesktop.org/review?bug=32326&attachment=41039
[PATCH] Don't even consider enabling microtiling unless DRM major version is 1.
If DRM v2.x doesn't support microtiling on R200 yet then the DRM version check in Mesa is no longer adequate.
https://bugs.freedesktop.org/show_bug.cgi?id=32326
--- Comment #6 from Matt Turner mattst88@gmail.com 2011-09-15 12:12:36 PDT --- (In reply to comment #5)
Created an attachment (id=41039)
View: https://bugs.freedesktop.org/attachment.cgi?id=41039 Review: https://bugs.freedesktop.org/review?bug=32326&attachment=41039
[PATCH] Don't even consider enabling microtiling unless DRM major version is 1.
If DRM v2.x doesn't support microtiling on R200 yet then the DRM version check in Mesa is no longer adequate.
Did you read/understand Dave's previous comment?
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org