From: Colin Ian King colin.king@canonical.com
Trivial fix to spelling mistake in DRM_ERROR error message text
Signed-off-by: Colin Ian King colin.king@canonical.com --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e42a28e3adc5..1df1c91b6ae5 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1521,7 +1521,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) break; #endif default: - DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type); + DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type); goto fail; }
@@ -1715,7 +1715,7 @@ static int dm_early_init(void *handle) break; #endif default: - DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type); + DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type); return -EINVAL; }
On 2018-03-30 12:00 PM, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
Trivial fix to spelling mistake in DRM_ERROR error message text
Signed-off-by: Colin Ian King colin.king@canonical.com
Reviewed-by: Harry Wentland harry.wentland@amd.com
Harry
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e42a28e3adc5..1df1c91b6ae5 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1521,7 +1521,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) break; #endif default:
DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);@@ -1715,7 +1715,7 @@ static int dm_early_init(void *handle) break; #endif default:
DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
On Mon, Apr 2, 2018 at 9:47 AM, Harry Wentland harry.wentland@amd.com wrote:
On 2018-03-30 12:00 PM, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
Trivial fix to spelling mistake in DRM_ERROR error message text
Signed-off-by: Colin Ian King colin.king@canonical.com
Reviewed-by: Harry Wentland harry.wentland@amd.com
Applied. Thanks!
Harry
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e42a28e3adc5..1df1c91b6ae5 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1521,7 +1521,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) break; #endif default:
DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type); goto fail; }@@ -1715,7 +1715,7 @@ static int dm_early_init(void *handle) break; #endif default:
DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type); return -EINVAL; }
amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Fri, 30 Mar 2018, Colin King colin.king@canonical.com wrote:
From: Colin Ian King colin.king@canonical.com
Trivial fix to spelling mistake in DRM_ERROR error message text
Thanks for the patch.
Please do consider limiting the distribution in the future, though. There's no need to include lkml or even dri-devel for trivial patches like this.
Thanks, Jani.
Signed-off-by: Colin Ian King colin.king@canonical.com
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e42a28e3adc5..1df1c91b6ae5 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1521,7 +1521,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) break; #endif default:
DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);@@ -1715,7 +1715,7 @@ static int dm_early_init(void *handle) break; #endif default:
DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
On Tue, 3 Apr 2018, Jani Nikula wrote:
On Fri, 30 Mar 2018, Colin King colin.king@canonical.com wrote:
From: Colin Ian King colin.king@canonical.com
Trivial fix to spelling mistake in DRM_ERROR error message text
Thanks for the patch.
Please do consider limiting the distribution in the future, though. There's no need to include lkml or even dri-devel for trivial patches like this.
It's complex to have to remember the preferences for every subsystem. Preferences should be expressed in the MAINTAINERS file in some way. Also, since no one reads lkml, does it hurt to have even trivial patches?
julia
Thanks, Jani.
Signed-off-by: Colin Ian King colin.king@canonical.com
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e42a28e3adc5..1df1c91b6ae5 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1521,7 +1521,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) break; #endif default:
DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);@@ -1715,7 +1715,7 @@ static int dm_early_init(void *handle) break; #endif default:
DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);-- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 03, 2018 at 11:41:05AM +0200, Julia Lawall wrote:
On Tue, 3 Apr 2018, Jani Nikula wrote:
On Fri, 30 Mar 2018, Colin King colin.king@canonical.com wrote:
From: Colin Ian King colin.king@canonical.com
Trivial fix to spelling mistake in DRM_ERROR error message text
Thanks for the patch.
Please do consider limiting the distribution in the future, though. There's no need to include lkml or even dri-devel for trivial patches like this.
It's complex to have to remember the preferences for every subsystem. Preferences should be expressed in the MAINTAINERS file in some way. Also, since no one reads lkml, does it hurt to have even trivial patches?
I always tell people not to CC lkml when there is a smaller subsystem list which can handle it but Linus said my advice was bad.
regards, dan carpenter
On Tue, 03 Apr 2018, Julia Lawall julia.lawall@lip6.fr wrote:
On Tue, 3 Apr 2018, Jani Nikula wrote:
Please do consider limiting the distribution in the future, though. There's no need to include lkml or even dri-devel for trivial patches like this.
It's complex to have to remember the preferences for every subsystem. Preferences should be expressed in the MAINTAINERS file in some way.
They are; it's just that get_maintainer.pl has silly defaults. There's no reason it should include the full chain from the leaf driver to the subsystem to the LKML by default, with a bunch of authors and commit signers on top. Especially so for supported drivers. I'm surprised it doesn't include Linus by default.
Also, since no one reads lkml, does it hurt to have even trivial patches?
Heh. Let's just say I care more about dri-devel.
BR, Jani.
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Colin King -
Dan Carpenter -
Harry Wentland -
Jani Nikula -
Julia Lawall