When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space.
Signed-off-by: Nicolas Pitre nico@linaro.org Cc: stable@kernel.org
diff --git a/drivers/video/console/dummycon.c b/drivers/video/console/dummycon.c index 9269d56852..b90ef96e43 100644 --- a/drivers/video/console/dummycon.c +++ b/drivers/video/console/dummycon.c @@ -67,7 +67,6 @@ const struct consw dummy_con = { .con_switch = DUMMY, .con_blank = DUMMY, .con_font_set = DUMMY, - .con_font_get = DUMMY, .con_font_default = DUMMY, .con_font_copy = DUMMY, };
On Friday, January 05, 2018 04:42:58 PM Nicolas Pitre wrote:
When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space.
Signed-off-by: Nicolas Pitre nico@linaro.org Cc: stable@kernel.org
Please check your patches with tools/checkpatch.pl script:
ERROR: The 'stable' address should be 'stable@vger.kernel.org' #9: Cc: stable@kernel.org
After updating this I queued the patch for 4.16, thanks.
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On Mon, 15 Jan 2018, Bartlomiej Zolnierkiewicz wrote:
On Friday, January 05, 2018 04:42:58 PM Nicolas Pitre wrote:
When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space.
Signed-off-by: Nicolas Pitre nico@linaro.org Cc: stable@kernel.org
Please check your patches with tools/checkpatch.pl script:
ERROR: The 'stable' address should be 'stable@vger.kernel.org' #9: Cc: stable@kernel.org
Oops. I cut and pasted it it from commit ea0ee33988778fb73e4f4. ;-)
Nicolas
dri-devel@lists.freedesktop.org
-
Bartlomiej Zolnierkiewicz -
Nicolas Pitre