[New] Create the setting for 1600x900 @60Hz refresh rate by 108MHz pixel-clock.
Signed-off-by: KuoHsiang Chou kuohsiang_chou@aspeedtech.com --- drivers/gpu/drm/ast/ast_tables.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h index d665dd5af5dd..8414e543f260 100644 --- a/drivers/gpu/drm/ast/ast_tables.h +++ b/drivers/gpu/drm/ast/ast_tables.h @@ -282,6 +282,8 @@ static const struct ast_vbios_enhtable res_1360x768[] = { };
static const struct ast_vbios_enhtable res_1600x900[] = { + {1800, 1600, 24, 80,1000, 900, 1, 3, VCLK108, /* 60Hz */ + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 3, 0x3A }, {1760, 1600, 48, 32, 926, 900, 3, 5, VCLK97_75, /* 60Hz CVT RB */ (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | AST2500PreCatchCRT), 60, 1, 0x3A }, -- 2.18.4
Hi KuoHsiang
On Fri, Oct 30, 2020 at 03:42:12PM +0800, KuoHsiang Chou wrote:
[New] Create the setting for 1600x900 @60Hz refresh rate by 108MHz pixel-clock.
Signed-off-by: KuoHsiang Chou kuohsiang_chou@aspeedtech.com
Thomas Zimmermann tzimmermann@suse.de is listed as reviewer in MAINTAINERS, so included him in the list of receiver. get_maintainer.pl should have told you that.
Sam
drivers/gpu/drm/ast/ast_tables.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h index d665dd5af5dd..8414e543f260 100644 --- a/drivers/gpu/drm/ast/ast_tables.h +++ b/drivers/gpu/drm/ast/ast_tables.h @@ -282,6 +282,8 @@ static const struct ast_vbios_enhtable res_1360x768[] = { };
static const struct ast_vbios_enhtable res_1600x900[] = {
- {1800, 1600, 24, 80,1000, 900, 1, 3, VCLK108, /* 60Hz */
(SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 3, 0x3A },-- 2.18.4
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi, Sam
Thanks for your teaching and the information got from v5.10-rc2 likes as
DRM DRIVER FOR AST SERVER GRAPHICS CHIPS M: Dave Airlie airlied@redhat.com R: Thomas Zimmermann tzimmermann@suse.de L: dri-devel@lists.freedesktop.org S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc F: drivers/gpu/drm/ast/
Regards, Kuo-Hsiang Chou
-----Original Message----- From: Sam Ravnborg [mailto:sam@ravnborg.org] Sent: Sunday, November 01, 2020 5:19 PM To: Kuo-Hsiang Chou kuohsiang_chou@aspeedtech.com; Thomas Zimmermann tzimmermann@suse.de Cc: dri-devel@lists.freedesktop.org; eich@suse.com; Tommy Huang tommy_huang@aspeedtech.com; Jenmin Yuan jenmin_yuan@aspeedtech.com; airlied@redhat.com; Arc Sung arc_sung@aspeedtech.com Subject: Re: [PATCH] drm/ast: Support 1600x900 with 108MHz PCLK
Hi KuoHsiang
On Fri, Oct 30, 2020 at 03:42:12PM +0800, KuoHsiang Chou wrote:
[New] Create the setting for 1600x900 @60Hz refresh rate by 108MHz pixel-clock.
Signed-off-by: KuoHsiang Chou kuohsiang_chou@aspeedtech.com
Thomas Zimmermann tzimmermann@suse.de is listed as reviewer in MAINTAINERS, so included him in the list of receiver. get_maintainer.pl should have told you that.
Sam
drivers/gpu/drm/ast/ast_tables.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h index d665dd5af5dd..8414e543f260 100644 --- a/drivers/gpu/drm/ast/ast_tables.h +++ b/drivers/gpu/drm/ast/ast_tables.h @@ -282,6 +282,8 @@ static const struct ast_vbios_enhtable res_1360x768[] = { };
static const struct ast_vbios_enhtable res_1600x900[] = {
- {1800, 1600, 24, 80,1000, 900, 1, 3, VCLK108, /* 60Hz */
(SyncPP | Charx8Dot | LineCompareOff | WideScreenMode |+NewModeInfo), 60, 3, 0x3A }, {1760, 1600, 48, 32, 926, 900, 3, 5, VCLK97_75, /* 60Hz CVT RB */ (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | AST2500PreCatchCRT), 60, 1, 0x3A }, -- 2.18.4
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi
Am 30.10.20 um 08:42 schrieb KuoHsiang Chou:
[New] Create the setting for 1600x900 @60Hz refresh rate by 108MHz pixel-clock.
Signed-off-by: KuoHsiang Chou kuohsiang_chou@aspeedtech.com
Acked-by: Thomas Zimmermann tzimmermann@suse.de
I'll add your patch to drm-misc-next.
As Sam mentioned, you should use scripts/get_maintainers.pl to retrieve the relevant people. These include those in MAINTAINERS, but also developers that have previously worked on the code.
The easiest way is
git format-patch <rev^1>...<rev>
which results in a patch file. Then do
scripts/get_maintainers.pl <filename>
on the file. Please also run
scripts/checkpatch.pl <filename>
on the file to get a report on potential errors.
Best regards Thomas
drivers/gpu/drm/ast/ast_tables.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h index d665dd5af5dd..8414e543f260 100644 --- a/drivers/gpu/drm/ast/ast_tables.h +++ b/drivers/gpu/drm/ast/ast_tables.h @@ -282,6 +282,8 @@ static const struct ast_vbios_enhtable res_1360x768[] = { };
static const struct ast_vbios_enhtable res_1600x900[] = {
- {1800, 1600, 24, 80,1000, 900, 1, 3, VCLK108, /* 60Hz */
(SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 3, 0x3A },-- 2.18.4
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, 2 Nov 2020 at 17:57, Thomas Zimmermann tzimmermann@suse.de wrote:
Hi
Am 30.10.20 um 08:42 schrieb KuoHsiang Chou:
[New] Create the setting for 1600x900 @60Hz refresh rate by 108MHz pixel-clock.
Signed-off-by: KuoHsiang Chou kuohsiang_chou@aspeedtech.com
Acked-by: Thomas Zimmermann tzimmermann@suse.de
I'll add your patch to drm-misc-next.
As Sam mentioned, you should use scripts/get_maintainers.pl to retrieve the relevant people. These include those in MAINTAINERS, but also developers that have previously worked on the code.
We are seeing a possible report of a regression on an ast2600 server with this patch.
I haven't ascertained that reverting it fixes it for the customer yet, but this is a heads up in case anyone else has seen issues.
Dave.
Hi
-----Original Message----- From: Dave Airlie [mailto:airlied@gmail.com] Sent: Wednesday, December 22, 2021 5:56 AM To: Thomas Zimmermann tzimmermann@suse.de
Subject: Re: [PATCH] drm/ast: Support 1600x900 with 108MHz PCLK
On Mon, 2 Nov 2020 at 17:57, Thomas Zimmermann tzimmermann@suse.de wrote:
Hi
Am 30.10.20 um 08:42 schrieb KuoHsiang Chou:
[New] Create the setting for 1600x900 @60Hz refresh rate by 108MHz pixel-clock.
Signed-off-by: KuoHsiang Chou kuohsiang_chou@aspeedtech.com
Acked-by: Thomas Zimmermann tzimmermann@suse.de
I'll add your patch to drm-misc-next.
As Sam mentioned, you should use scripts/get_maintainers.pl to retrieve the relevant people. These include those in MAINTAINERS, but also developers that have previously worked on the code.
We are seeing a possible report of a regression on an ast2600 server with this patch.
I haven't ascertained that reverting it fixes it for the customer yet, but this is a heads up in case anyone else has seen issues.
Hi Dave,
Yes, you're right, The patch needs to be removed. The patch occurs incorrect timing on CRT and ASTDP when 1600x900 are selected. So, do I need to commit a new patch to remove/revert it from drm/ast?
Regards, Kuo-Hsiang Chou
Dave.
On Wed, 22 Dec 2021 at 11:19, Kuo-Hsiang Chou kuohsiang_chou@aspeedtech.com wrote:
Hi
-----Original Message----- From: Dave Airlie [mailto:airlied@gmail.com] Sent: Wednesday, December 22, 2021 5:56 AM To: Thomas Zimmermann tzimmermann@suse.de
Subject: Re: [PATCH] drm/ast: Support 1600x900 with 108MHz PCLK
On Mon, 2 Nov 2020 at 17:57, Thomas Zimmermann tzimmermann@suse.de wrote:
Hi
Am 30.10.20 um 08:42 schrieb KuoHsiang Chou:
[New] Create the setting for 1600x900 @60Hz refresh rate by 108MHz pixel-clock.
Signed-off-by: KuoHsiang Chou kuohsiang_chou@aspeedtech.com
Acked-by: Thomas Zimmermann tzimmermann@suse.de
I'll add your patch to drm-misc-next.
As Sam mentioned, you should use scripts/get_maintainers.pl to retrieve the relevant people. These include those in MAINTAINERS, but also developers that have previously worked on the code.
We are seeing a possible report of a regression on an ast2600 server with this patch.
I haven't ascertained that reverting it fixes it for the customer yet, but this is a heads up in case anyone else has seen issues.
Hi Dave,
Yes, you're right, The patch needs to be removed. The patch occurs incorrect timing on CRT and ASTDP when 1600x900 are selected. So, do I need to commit a new patch to remove/revert it from drm/ast?
Yes, do a git revert <commitd>
Fixup the resulting message, to say why, and add a Fixes: <12 chars of sha1> ("commitmsg")
and send to the list. Dave.
dri-devel@lists.freedesktop.org
-
Dave Airlie -
Kuo-Hsiang Chou -
KuoHsiang Chou
-
Sam Ravnborg -
Thomas Zimmermann