On Fri, Feb 15, 2019 at 5:40 PM Gustavo A. R. Silva gustavo@embeddedor.com wrote:

Add missing break statement in order to prevent the code from falling through to case CB_TARGET_MASK.

This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough.

Fixes: dd220a00e8bd ("drm/radeon/kms: add support for streamout v7") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva gustavo@embeddedor.com

---

NOTE: Notice that this code has been out there since 2012. So, it would be helpful if someone can double-check this.

Applied. thanks!

Alex

drivers/gpu/drm/radeon/evergreen_cs.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c index f471537c852f..1e14c6921454 100644 --- a/drivers/gpu/drm/radeon/evergreen_cs.c +++ b/drivers/gpu/drm/radeon/evergreen_cs.c @@ -1299,6 +1299,7 @@ static int evergreen_cs_handle_reg(struct radeon_cs_parser *p, u32 reg, u32 idx) return -EINVAL; } ib[idx] += (u32)((reloc->gpu_offset >> 8) & 0xffffffff);

•           break;
    case CB_TARGET_MASK:
            track->cb_target_mask = radeon_get_ib_value(p, idx);
            track->cb_dirty = true;
  

-- 2.20.1

---

amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx