From: Markus Elfring elfring@users.sourceforge.net Date: Sun, 5 Apr 2020 13:45:53 +0200
The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index 624437b27cdc..359b56e43b83 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -812,10 +812,8 @@ static int sun4i_tcon_init_irq(struct device *dev, int irq, ret;
irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "Couldn't retrieve the TCON interrupt\n"); + if (irq < 0) return irq; - }
ret = devm_request_irq(dev, irq, sun4i_tcon_handler, 0, dev_name(dev), tcon); -- 2.26.0
On Sun, Apr 05, 2020 at 01:53:05PM +0200, Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Sun, 5 Apr 2020 13:45:53 +0200
The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net
Applied, thanks
Maxime
dri-devel@lists.freedesktop.org