On Thu, Apr 22, 2021 at 07:51:46PM +0200, Fabio M. De Francesco wrote:

drm_send_event_helper() has not prototype, it has internal linkage and therefore it should be defined with storage class 'static'.

Signed-off-by: Fabio M. De Francesco fmdefrancesco@gmail.com

drivers/gpu/drm/drm_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index 7efbccffc2ea..17f38d873972 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/drm/drm_file.c @@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);

• The timestamp variant of dma_fence_signal is used when the caller
• sends a valid timestamp.

*/

Right above is the kerneldoc comment for documented the driver api that teh subsystem exposes. Generally we remove those when there's nothing interesting in there when making a function static, which is the case here. Can you pls do that too in v2?

Thanks, Daniel

-void drm_send_event_helper(struct drm_device *dev, +static void drm_send_event_helper(struct drm_device *dev, struct drm_pending_event *e, ktime_t timestamp) { assert_spin_locked(&dev->event_lock); -- 2.31.1