… to fix it.
I suggest to replace this wording by the tag “Fixes”.
…
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -276,8 +276,10 @@ nouveau_bo_alloc(struct nouveau_cli *cli, u64 *size, int *align, u32 flags, break; }
- if (WARN_ON(pi < 0))
- if (WARN_ON(pi < 0)) {
return ERR_PTR(-EINVAL);kfree(nvbo);
- }
I propose to move such common exception handling to the end of this function implementation so that a bit of duplicate code will be avoided. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...
Regards, Markus
dri-devel@lists.freedesktop.org