On 08/07/2021 08:34, ChunyouTang wrote:

From: ChunyouTang tangchunyou@icubecorp.cn

The exception_code in register is only 8 bits,So if fault_status in panfrost_gpu_irq_handler() don't (& 0xFF),it can't get correct exception reason.

and it's better to show all of the register value to custom,so it's better fault_status don't (& 0xFF).

Signed-off-by: ChunyouTang tangchunyou@icubecorp.cn

Reviewed-by: Steven Price steven.price@arm.com

Boris's change has actually modified panfrost_exception_name() to no longer take pfdev in drm-misc-next. However, I'll just fix this up when I apply it.

Thanks,

Steve

---

drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c index 1fffb6a0b24f..d2d287bbf4e7 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -33,7 +33,7 @@ static irqreturn_t panfrost_gpu_irq_handler(int irq, void *data) address |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO);

dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",

• 	 fault_status & 0xFF, panfrost_exception_name(pfdev, fault_status & 0xFF),
  

• 	 fault_status, panfrost_exception_name(pfdev, fault_status & 0xFF),
   address);
  
  

  if (state & GPU_IRQ_MULTIPLE_FAULT)