[Bug 92765] Linux 4.1.12+, 4.2.5+ -> drm:radeon_pm_late_init [radeon]] *ERROR* + WARNING: CPU: 0 PID: 686 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x80() +
https://bugs.freedesktop.org/show_bug.cgi?id=92765
Bug ID: 92765 Summary: Linux 4.1.12+, 4.2.5+ -> drm:radeon_pm_late_init [radeon]] *ERROR* + WARNING: CPU: 0 PID: 686 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x80() + Product: Mesa Version: 11.0 Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: lblmr@yopmail.com QA Contact: dri-devel@lists.freedesktop.org
Hey guys.
Since I've upgraded to 4.1.12 from 4.1.11 I've been getting some errors:
Oct 29 05:26:43 hosty kernel: radeon 0000:01:00.0: WB enabled Oct 29 05:26:43 hosty kernel: radeon 0000:01:00.0: fence driver on ring 0 use gpu addr 0x0000000080000c00 and cpu addr 0xffff8800cbbdec00 Oct 29 05:26:43 hosty kernel: radeon 0000:01:00.0: fence driver on ring 1 use gpu addr 0x0000000080000c04 and cpu addr 0xffff8800cbbdec04 Oct 29 05:26:43 hosty kernel: radeon 0000:01:00.0: fence driver on ring 2 use gpu addr 0x0000000080000c08 and cpu addr 0xffff8800cbbdec08 Oct 29 05:26:43 hosty kernel: radeon 0000:01:00.0: fence driver on ring 3 use gpu addr 0x0000000080000c0c and cpu addr 0xffff8800cbbdec0c Oct 29 05:26:43 hosty kernel: radeon 0000:01:00.0: fence driver on ring 4 use gpu addr 0x0000000080000c10 and cpu addr 0xffff8800cbbdec10 Oct 29 05:26:43 hosty kernel: [drm] ring test on 0 succeeded in 1 usecs Oct 29 05:26:43 hosty kernel: [drm] ring test on 1 succeeded in 1 usecs Oct 29 05:26:43 hosty kernel: [drm] ring test on 2 succeeded in 1 usecs Oct 29 05:26:43 hosty kernel: [drm] ring test on 3 succeeded in 3 usecs Oct 29 05:26:43 hosty kernel: [drm] ring test on 4 succeeded in 3 usecs Oct 29 05:26:43 hosty kernel: [drm] ib test on ring 0 succeeded in 0 usecs Oct 29 05:26:43 hosty kernel: [drm] ib test on ring 1 succeeded in 0 usecs Oct 29 05:26:43 hosty kernel: [drm] ib test on ring 2 succeeded in 0 usecs Oct 29 05:26:43 hosty kernel: [drm] ib test on ring 3 succeeded in 0 usecs Oct 29 05:26:43 hosty kernel: [drm] ib test on ring 4 succeeded in 0 usecs Oct 29 05:26:43 hosty kernel: ------------[ cut here ]------------ Oct 29 05:26:43 hosty kernel: WARNING: CPU: 0 PID: 686 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x80() Oct 29 05:26:43 hosty kernel: sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:01.0/0000:01:00.0/power_dpm_state' Oct 29 05:26:43 hosty kernel: Modules linked in: uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_core v4l2_common videodev media joydev snd_hda_codec_hdmi mousedev snd_hda_codec_realtek snd_hda_ Oct 29 05:26:43 hosty kernel: drm snd_pcm ie31200_edac ptp mei_me snd_timer mei pps_core intel_gtt snd i2c_algo_bit regmap_i2c soundcore i2c_hid shpchp edac_core i2c_designware_platform parport_pc wm Oct 29 05:26:43 hosty kernel: CPU: 0 PID: 686 Comm: Xorg.wrap Tainted: G U O 4.1.12-1-ck #1 Oct 29 05:26:43 hosty kernel: Hardware name: Dell Inc. Latitude E6440/0K9GNV, BIOS A13 09/01/2015 Oct 29 05:26:43 hosty kernel: 0000000000000000 00000000f4e85e22 ffff88021d917778 ffffffff8156f7ac Oct 29 05:26:43 hosty kernel: 0000000000000000 ffff88021d9177d0 ffff88021d9177b8 ffffffff81077a3a Oct 29 05:26:43 hosty kernel: 000064d01d9177b8 ffff88021f4f3000 ffffffffa08e6470 ffff88022480f168 Oct 29 05:26:43 hosty kernel: Call Trace: Oct 29 05:26:43 hosty kernel: [<ffffffff8156f7ac>] dump_stack+0x4c/0x6e Oct 29 05:26:43 hosty kernel: [<ffffffff81077a3a>] warn_slowpath_common+0x8a/0xc0 Oct 29 05:26:43 hosty kernel: [<ffffffff81077ac5>] warn_slowpath_fmt+0x55/0x70 Oct 29 05:26:43 hosty kernel: [<ffffffff81238c58>] ? kernfs_path+0x48/0x60 Oct 29 05:26:43 hosty kernel: [<ffffffff8123c538>] sysfs_warn_dup+0x68/0x80 Oct 29 05:26:43 hosty kernel: [<ffffffff8123c217>] sysfs_add_file_mode_ns+0x147/0x1b0 Oct 29 05:26:43 hosty kernel: [<ffffffff8123c2aa>] sysfs_create_file_ns+0x2a/0x40 Oct 29 05:26:43 hosty kernel: [<ffffffff813d80c6>] device_create_file+0x46/0xb0 Oct 29 05:26:43 hosty kernel: [<ffffffffa08081c8>] radeon_pm_late_init+0x88/0x1d0 [radeon] Oct 29 05:26:43 hosty kernel: [<ffffffffa0798c23>] radeon_resume_kms+0x283/0x420 [radeon] Oct 29 05:26:43 hosty kernel: [<ffffffffa0796143>] radeon_pmops_runtime_resume+0x73/0xb0 [radeon] Oct 29 05:26:43 hosty kernel: [<ffffffff812fb1bf>] pci_pm_runtime_resume+0x7f/0xc0 Oct 29 05:26:43 hosty kernel: [<ffffffff813d5050>] ? vga_switcheroo_runtime_suspend+0x60/0x60 Oct 29 05:26:43 hosty kernel: [<ffffffff813d5089>] vga_switcheroo_runtime_resume+0x39/0x40 Oct 29 05:26:43 hosty kernel: [<ffffffff813e7326>] __rpm_callback+0x36/0x90 Oct 29 05:26:43 hosty kernel: [<ffffffff813e73a8>] rpm_callback+0x28/0x90 Oct 29 05:26:43 hosty kernel: [<ffffffff813e87de>] rpm_resume+0x4ce/0x6b0 Oct 29 05:26:43 hosty kernel: [<ffffffff813e89ff>] __pm_runtime_resume+0x3f/0x60 Oct 29 05:26:43 hosty kernel: [<ffffffffa079b006>] radeon_driver_open_kms+0x36/0x1d0 [radeon] Oct 29 05:26:43 hosty kernel: [<ffffffff812632c8>] ? security_capable+0x18/0x20 Oct 29 05:26:43 hosty kernel: [<ffffffffa043185f>] drm_open+0x1af/0x4c0 [drm] Oct 29 05:26:43 hosty kernel: [<ffffffff811c61f1>] ? exact_lock+0x11/0x20 Oct 29 05:26:43 hosty kernel: [<ffffffffa0438789>] drm_stub_open+0xa9/0x120 [drm] Oct 29 05:26:43 hosty kernel: [<ffffffff811c65ce>] chrdev_open+0xae/0x1f0 Oct 29 05:26:43 hosty kernel: [<ffffffff811bf4f7>] do_dentry_open+0x227/0x330 Oct 29 05:26:43 hosty kernel: [<ffffffff811c6520>] ? cdev_put+0x30/0x30 Oct 29 05:26:43 hosty kernel: [<ffffffff811c0736>] vfs_open+0x56/0x60 Oct 29 05:26:43 hosty kernel: [<ffffffff811d0354>] do_last.isra.11+0x344/0xf60 Oct 29 05:26:43 hosty kernel: [<ffffffff811ceb1e>] ? path_init+0x17e/0x460 Oct 29 05:26:43 hosty kernel: [<ffffffff811d1001>] path_openat+0x91/0x690 Oct 29 05:26:43 hosty kernel: [<ffffffff811d2a99>] do_filp_open+0x49/0xd0 Oct 29 05:26:43 hosty kernel: [<ffffffff812c76ca>] ? find_next_zero_bit+0x1a/0x30 Oct 29 05:26:43 hosty kernel: [<ffffffff811e00b7>] ? __alloc_fd+0xa7/0x130 Oct 29 05:26:43 hosty kernel: [<ffffffff811c0b3d>] do_sys_open+0x14d/0x250 Oct 29 05:26:43 hosty kernel: [<ffffffff811c0c5e>] SyS_open+0x1e/0x20 Oct 29 05:26:43 hosty kernel: [<ffffffff8157566e>] system_call_fastpath+0x12/0x71 Oct 29 05:26:43 hosty kernel: ---[ end trace 1148860c62f9432d ]--- Oct 29 05:26:43 hosty kernel: [drm:radeon_pm_late_init [radeon]] *ERROR* failed to create device file for dpm state Oct 29 05:26:43 hosty kernel: ------------[ cut here ]------------
This is when I start the X server/ power off / reboot / resume from suspend :
Oct 29 05:25:40 hosty kernel: [drm:radeon_pm_late_init [radeon]] *ERROR* failed to create device file for dpm state Oct 29 05:25:40 hosty kernel: [drm:radeon_pm_late_init [radeon]] *ERROR* failed to create device file for dpm state Oct 29 05:25:40 hosty kernel: [drm:radeon_pm_late_init [radeon]] *ERROR* failed to create device file for power profile Oct 29 05:25:40 hosty kernel: [drm:radeon_pm_late_init [radeon]] *ERROR* failed to create device file for power method
Found something related: https://lkml.org/lkml/2015/10/26/780
Right now I'm running the -ck patch, but it behaves the same on the generic one
Hw: DGPU 01:00.0 Display controller: Advanced Micro Devices, Inc. [AMD/ATI] Sun XT [Radeon HD 8670A/8670M/8690M / R5 M330] (rev ff)
OS: ArchLinux
It didn't happen on Linux 4.1.11 and 4.2.4.
I think this is the commit that messed it up: ============================================================== commit 4e4887f08f2ece9e7f1975af4c3dc797b1ad557b Author: Alex Deucher alexander.deucher@amd.com Date: Wed Sep 30 16:45:52 2015 -0400
drm/radeon: add pm sysfs files late
commit 51a4726b04e880fdd9b4e0e58b13f70b0a68a7f5 upstream.
They were added relatively early in the driver init process which meant that in some cases the driver was not finished initializing before external tools tried to use them which could result in a crash depending on the timing.
Signed-off-by: Alex Deucher alexander.deucher@amd.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org ==============================================================
https://bugs.freedesktop.org/show_bug.cgi?id=92765
Alex Deucher alexdeucher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Component|Drivers/Gallium/radeonsi |DRM/Radeon Version|11.0 |unspecified Resolution|--- |FIXED Product|Mesa |DRI QA Contact|dri-devel@lists.freedesktop | |.org |
--- Comment #1 from Alex Deucher alexdeucher@gmail.com --- Fixed in: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=49...
On Mon, 02 Nov 2015 05:39:20 +0000, bugzilla-daemon wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=92765
Alex Deucher alexdeucher@gmail.com changed:
What |Removed |Added
Status|NEW |RESOLVED Component|Drivers/Gallium/radeonsi |DRM/Radeon Version|11.0 |unspecified Resolution|--- |FIXED Product|Mesa |DRI QA Contact|dri-devel@lists.freedesktop | |.org |--- Comment #1 from Alex Deucher alexdeucher@gmail.com --- Fixed in: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=49...
Alex, I don't know why there are two different bugzillas for this, but please take a look at https://bugzilla.kernel.org/show_bug.cgi?id=106851 because the issue does not seem to be fixed by that patch at all.
-h
On Mon, Nov 2, 2015 at 5:09 AM, Holger Hoffstätte holger.hoffstaette@googlemail.com wrote:
On Mon, 02 Nov 2015 05:39:20 +0000, bugzilla-daemon wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=92765
Alex Deucher alexdeucher@gmail.com changed:
What |Removed |Added
Status|NEW |RESOLVED Component|Drivers/Gallium/radeonsi |DRM/Radeon Version|11.0 |unspecified Resolution|--- |FIXED Product|Mesa |DRI QA Contact|dri-devel@lists.freedesktop | |.org |--- Comment #1 from Alex Deucher alexdeucher@gmail.com --- Fixed in: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=49...
Alex, I don't know why there are two different bugzillas for this, but please take a look at https://bugzilla.kernel.org/show_bug.cgi?id=106851 because the issue does not seem to be fixed by that patch at all.
You should figure out what the files are failing to registers in the first place on your system. Setting the flag unconditionally just fixes a symptom. I'll change the code to set the flag unconditionally to avoid the error spew on resume, but it's really just papering over the real problem on your board.
Alex
On Mon, 02 Nov 2015 10:11:45 -0500, Alex Deucher wrote:
Fixed in: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=49...
Alex, I don't know why there are two different bugzillas for this, but please take a look at https://bugzilla.kernel.org/show_bug.cgi?id=106851 because the issue does not seem to be fixed by that patch at all.
You should figure out what the files are failing to registers in the first place on your system. Setting the flag unconditionally just fixes a symptom. I'll change the code to set the flag unconditionally to avoid the error spew on resume, but it's really just papering over the real problem on your board.
Normally I'd agree (I understand what the code does), but I don't have any errors - and all sysfs entries! - after boot, so as far as I can tell the flag isn't set properly even after a successful boot, and then leads to spews on resume. Maybe the entire process is racy somehow?
My card is an admittedly old, but perfectly working fanless (!) HD 5500, 1GB RAM, driver is r600 and everything - including dpms, suspend/wakeup etc. works fine. I tried to disable dpm on boot and that of course stopped the warnings, but then the card was constantly at ~55° instead of the usual ~45°, for no noticeably win in performance.
If you have any other suggestions or patches for me to try I'd be glad to test/verify. In the meantime I think setting the flag is the easiest fix; it certainly works for me.
Thanks for looking into it!
cheers Holger
dri-devel@lists.freedesktop.org
-
Alex Deucher -
bugzilla-daemon＠freedesktop.org -
Holger Hoffstätte