On Sun, Sep 08, 2019 at 02:34:50PM +1000, Adam Zerella wrote:

Using strncpy() does not always terminate the destination string. stracpy() is a alternative function that does, by using this new function we will no longer need to insert a null separator.

Signed-off-by: Adam Zerella adam.zerella@gmail.com

drivers/staging/android/ion/ion.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index e6b1ca141b93..17901bd626be 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -433,8 +433,7 @@ static int ion_query_heaps(struct ion_heap_query *query) max_cnt = query->cnt;

plist_for_each_entry(heap, &dev->heaps, node) {

• strncpy(hdata.name, heap->name, MAX_HEAP_NAME);
  

• hdata.name[sizeof(hdata.name) - 1] = '\0';
  

• stracpy(hdata.name, heap->name, MAX_HEAP_NAME);
  

stracpy() only takes two arguments. This doesn't compile.

regards, dan carpenter