Hi Qian,

Thank you for the patch.

On Sun, Jun 07, 2020 at 09:48:18PM -0400, Qian Cai wrote:

There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make the generated .config a bit ugly.

# ARM devices # # end of ARM devices

CONFIG_DRM_RCAR_WRITEBACK=y

# # Frame buffer Devices

Signed-off-by: Qian Cai cai@lca.pw

drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index 0919f1f159a4..d80696455d3e 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64

• depends on DRM

How about depending on DRM_RCAR_DU instead, as DRM_RCAR_WRITEBACK is used to select compilation of rcar_du_writeback.c that is part of the rcar-du driver ?