DRM probe should not repoll a connector if it is already connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set.
Signed-off-by: Josef Holzmayr holzmayr@rsi-elektrotechnik.de --- drivers/gpu/drm/drm_probe_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index 3fee587..1a52ea2 100644 --- a/drivers/gpu/drm/drm_probe_helper.c +++ b/drivers/gpu/drm/drm_probe_helper.c @@ -323,8 +323,6 @@ static void output_poll_execute(struct work_struct *work) if (!connector->polled || connector->polled == DRM_CONNECTOR_POLL_HPD) continue;
- repoll = true; - old_status = connector->status; /* if we are connected and don't want to poll for disconnect skip it */ @@ -332,6 +330,8 @@ static void output_poll_execute(struct work_struct *work) !(connector->polled & DRM_CONNECTOR_POLL_DISCONNECT)) continue;
+ repoll = true; + connector->status = connector->funcs->detect(connector, false); if (old_status != connector->status) { const char *old, *new;
On Thu, Apr 16, 2015 at 02:16:29PM +0200, Josef Holzmayr wrote:
DRM probe should not repoll a connector if it is already connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set.
Signed-off-by: Josef Holzmayr holzmayr@rsi-elektrotechnik.de
However, this requires review of all current users first to check for masked bugs. So at least cc every driver maintainer. -Chris
Am 17.04.2015 um 13:23 schrieb Chris Wilson:
On Thu, Apr 16, 2015 at 02:16:29PM +0200, Josef Holzmayr wrote:
DRM probe should not repoll a connector if it is already connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set.
Signed-off-by: Josef Holzmayr holzmayr@rsi-elektrotechnik.de
However, this requires review of all current users first to check for masked bugs. So at least cc every driver maintainer.
Happily will do, is there some kind of list or resource to follow? I just started out with what get_maintainer.pl told me.
Greetz
On Fri, Apr 17, 2015 at 01:26:21PM +0200, Josef Holzmayr wrote:
Am 17.04.2015 um 13:23 schrieb Chris Wilson:
On Thu, Apr 16, 2015 at 02:16:29PM +0200, Josef Holzmayr wrote:
DRM probe should not repoll a connector if it is already connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set.
Signed-off-by: Josef Holzmayr holzmayr@rsi-elektrotechnik.de
However, this requires review of all current users first to check for masked bugs. So at least cc every driver maintainer.
Happily will do, is there some kind of list or resource to follow? I just started out with what get_maintainer.pl told me.
Sending to dri-devel should be enough generally. I've pulled this into topic/drm-misc for 4.2, hopefully that's enough testing to figure out whether anything is broken with this patch. -Daniel
dri-devel@lists.freedesktop.org