Re: [PATCH] gma500:Remove functions that are now deprecated and move to the newer functions in drm_dp_helper.c
On Mon, May 11, 2015 at 5:54 PM, Nicholas Krause xerofoify@gmail.com wrote:
On May 11, 2015 4:24:01 AM EDT, Patrik Jakobsson patrik.r.jakobsson@gmail.com wrote:
On Sun, May 10, 2015 at 9:50 PM, Nicholas Krause xerofoify@gmail.com wrote:
On May 10, 2015 3:45:36 PM EDT, patrik.r.jakobsson@gmail.com wrote:
On Sun, May 10, 2015 at 02:40:40PM -0400, nick wrote:
On 2015-05-10 02:35 PM, patrik.r.jakobsson@gmail.com wrote:
On Sun, May 10, 2015 at 01:48:14PM -0400, nick wrote: > > > On 2015-05-10 01:04 PM, patrik.r.jakobsson@gmail.com wrote: >> On Tue, May 05, 2015 at 11:17:07AM -0400, nick wrote: >>> >>> >>> On 2015-05-05 09:06 AM, Patrik Jakobsson wrote: >>>> On Tue, May 5, 2015 at 12:29 AM, Nicholas Krause
xerofoify@gmail.com wrote:
>>>>> This removes the deprecated functions,i2c_dp_aux_add_bus and >>>>> i2c_dp_aux_prepare_bus and the only call in the function, >>>>> cdv_intel_dp_i2c_init to i2c_dp_aux_add_bus respectfully. >>>>> The call and use of these functions is now replaced
alongside
>>>>> the removal of setting other values in the
function,cdv_intel_dp_i2c_init
>>>>> to use the helper function, drm_dp_aux_register that can
handle all this
>>>>> work internally. >>>> >>>> You need to fill in the drm_dp_aux structure and implement a
proper transfer
>>>> function. This patch would only break things. But the cdv dp
output is already
>>>> broken on my system so it needs fixing first. >>>> >>>> -Patrik >>>> >>> Patrik, >>> Due to me not being an expert in this area of the kernel I
based
my work off the similar function,
>>> intel_dp_aux_init for i915. I was unsure of which helper
functions for i915 need to be written
>>> differently for gma500 based solutions as I don't known the
differences between these two in the
>>> graphics specs area. >>> Thanks, >>> Nick >> >> Hi Nick >> You are _required_ to know what your patches are doing before
sending them. If
>> you don't test your code and don't know what it's doing then we
will not accept
>> it. You're expected to read the available documentation and
relevant literature
>> before sending patches and asking questions. Otherwise someone
else is doing the
>> work for you, which I assume is not the purpose of you patch
submission.
>> >> Thanks >> Patrik
> Patrik, > Sorry about that my question is actually this ,I am unsure of
what
parts of the function,intel_dp_aux_init
> need to be ported for the gma500 gpu driver. Furthermore I will
list what parts for certain I known need to
> be ported over above the lines of code in the function
definition
I have pasted below. Please let me known
> if there are any areas I am missing. This is more just of a
double
check to make sure I don't miss something
> critical:)(I like to verify something before I code it). > Sorry for the misunderstanding,
You can figure this out by reading the drm dp helpers docs and
looking at
cdv_intel_dp.c. For instance, in gma500 we initialize DP_B and
DP_C.
My point is that _you_ need to read the code and understand it. I
cannot help
you with that.
But as I said in my first reply. DP on CDV is broken (at least on
my machine) so
that should be fixed first.
Cheers Patrik
Patrik, Sorry about that :). Your right it's a bad habit :(, I will start
working on it.
Further more by "broken" you mean what. This is very vague and if
you
would like
some help with it, I am willing to if you can give me a detailed
response of what
is wrong. Nick
Vague? Both DP and LVDS displays are black after boot when DP is connected. What additional information do you need?
That sounds broken to me. This seems like a good place to start
helping a new with your permission.
Nick
Sorry but I'm no teacher and cannot help you with that.
Patrik
That's not what I meant in terms of teaching me. I asked if you want help solving this issue with your machine. Nick
Sure. What info do you need?
dri-devel@lists.freedesktop.org
-
Patrik Jakobsson