https://bugs.freedesktop.org/show_bug.cgi?id=96239
Bug ID: 96239 Summary: Random "texture flickering" in Shadow of Mordor Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: 0xe2.0x9a.0x9b@gmail.com QA Contact: dri-devel@lists.freedesktop.org
Created attachment 124124 --> https://bugs.freedesktop.org/attachment.cgi?id=124124&action=edit Screenshot
See the screenshot attached to this bug.
GPU: R9 390 OpenGL version string: 4.3 (Core Profile) Mesa 11.3.0-devel (git-8314dd7)
$ export MESA_GLSL_VERSION_OVERRIDE=430
This may be related to the off-chip tessellation patches, but the issue doesn't depend on whether tessellation is enabled or disabled.
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #1 from Jan Ziak 0xe2.0x9a.0x9b@gmail.com --- Created attachment 124125 --> https://bugs.freedesktop.org/attachment.cgi?id=124125&action=edit Tomb Raider with tessellation
Tomb Raider without tessellation: OK Tomb Raider with tessellation: random flickering
https://bugs.freedesktop.org/show_bug.cgi?id=96239
Jan Ziak 0xe2.0x9a.0x9b@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Random "texture flickering" |[radeonsi tessellation] |in Shadow of Mordor |Random "texture flickering" | |(Shadow of Mordor, Tomb | |Raider)
https://bugs.freedesktop.org/show_bug.cgi?id=96239
Jan Ziak 0xe2.0x9a.0x9b@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #124124|Screenshot |Shadow of Mordor screenshot description| |
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #2 from prazola sostermino@yahoo.it --- I confirm the bug. It affects tessellation on heaven benchmark 4.0. r9 390.
https://bugs.freedesktop.org/show_bug.cgi?id=96239
prazola sostermino@yahoo.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|[radeonsi tessellation] |[radeonsi tessellation] |Random "texture flickering" |Random "texture flickering" |(Shadow of Mordor, Tomb |(Shadow of Mordor, Tomb |Raider) |Raider, Unigine Heaven 4.0)
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #3 from Clésio Luiz magolobel@yahoo.com.br --- This affect me too, in a R9 290, radeonsi driver, using padoka PPA with Kubuntu 16.04.
When you disable tesselation in those games the problem goes away.
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #4 from Bas Nieuwenhuizen bas@basnieuwenhuizen.nl --- Created attachment 124151 --> https://bugs.freedesktop.org/attachment.cgi?id=124151&action=edit ci-64-tess-blocks.patch
Does the attached patch help? If not I would appreciate it if someone could find the first commit that fails (using e.g. bisect).
Also, I noticed all reporters use hawaii/grenada pro chips. If anyone with a different chip also has this issue, please let me know.
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #5 from Rafael Castillo jrch2k10@gmail.com --- i can confirm this patches generates 0 issues on TAHITI R9-280 and CAPE VERDE HD7700, so it seems it is specific to hawaii/grenada pro
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #6 from Jan Ziak 0xe2.0x9a.0x9b@gmail.com --- (In reply to Bas Nieuwenhuizen from comment #4)
Created attachment 124151 [details] [review] ci-64-tess-blocks.patch
Does the attached patch help? If not I would appreciate it if someone could find the first commit that fails (using e.g. bisect).
Also, I noticed all reporters use hawaii/grenada pro chips. If anyone with a different chip also has this issue, please let me know.
Unfortunately, ci-64-tess-blocks.patch is making the issue more severe. The frequency of "black triangles on screen" in Tomb Raider is higher.
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #7 from Jan Ziak 0xe2.0x9a.0x9b@gmail.com --- Created attachment 124154 --> https://bugs.freedesktop.org/attachment.cgi?id=124154&action=edit Tomb Raider ci-64-tess-blocks screenshot
https://bugs.freedesktop.org/show_bug.cgi?id=96239
Jan Ziak 0xe2.0x9a.0x9b@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|[radeonsi tessellation] |[radeonsi tessellation] [R9 |Random "texture flickering" |290/390] Random "texture |(Shadow of Mordor, Tomb |flickering" (Shadow of |Raider, Unigine Heaven 4.0) |Mordor, Tomb Raider, | |Unigine Heaven 4.0)
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #8 from Jan Ziak 0xe2.0x9a.0x9b@gmail.com --- (In reply to Bas Nieuwenhuizen from comment #4)
Does the attached patch help? If not I would appreciate it if someone could find the first commit that fails (using e.g. bisect).
Checking out for example f91c85b29b8261ab3f44d292ed2130d4f577d976 and starting Tomb Raider restarts the X server on my machine.
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #9 from Jan Ziak 0xe2.0x9a.0x9b@gmail.com --- Created attachment 124155 --> https://bugs.freedesktop.org/attachment.cgi?id=124155&action=edit S_03093C_OFFCHIP_BUFFERING(offchip_blocks) if >= CIK
This patch fixes the issue on my R9 390.
The code is just a guesswork. Maybe it should be (2*offchip_blocks-1) instead?
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #10 from Jan Ziak 0xe2.0x9a.0x9b@gmail.com --- Passing +1 to S_03093C_OFFCHIP_BUFFERING() explains why changing offchip_blocks from 256 to 64 increases the severity of the issue.
https://bugs.freedesktop.org/show_bug.cgi?id=96239
--- Comment #11 from Bas Nieuwenhuizen bas@basnieuwenhuizen.nl --- Thanks a lot for finding the cause of the issue.
I pushed e9d3246a7a74282fbbf95ed077e3c3b7750c8ddd to git, that patch should fix the issue.
https://bugs.freedesktop.org/show_bug.cgi?id=96239
Jan Ziak 0xe2.0x9a.0x9b@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #12 from Jan Ziak 0xe2.0x9a.0x9b@gmail.com --- Fixed. Shadow of Mordor renders OK.
dri-devel@lists.freedesktop.org