On 01/15, Sumera Priyadarsini wrote:

On Fri, Jan 15, 2021 at 6:39 PM Colin King colin.king@canonical.com wrote:

...

From: Colin Ian King colin.king@canonical.com

Currently the kmalloc allocation for config is not being null checked and could potentially lead to a null pointer dereference. Fix this by adding the missing null check.

Addresses-Coverity: ("Dereference null return value") Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type") Signed-off-by: Colin Ian King colin.king@canonical.com

Good catch, thank you!

Reviewed-by: Sumera Priyadarsini sylphrenadin@gmail.com

Applied to drm-misc-next.

Thanks, Melissa Wen

...

---

drivers/gpu/drm/vkms/vkms_drv.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 708f7f54001d..2173b82606f6 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -188,7 +188,11 @@ static int vkms_create(struct vkms_config *config)

static int __init vkms_init(void) {

•   struct vkms_config *config = kmalloc(sizeof(*config), GFP_KERNEL);
  

•   struct vkms_config *config;
  

•   config = kmalloc(sizeof(*config), GFP_KERNEL);
  

•   if (!config)
  

•           return -ENOMEM;
  
    default_config = config;
  
  

-- 2.29.2

regards, Sumera