This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions.
v2: * use prefix drm/amdgpu
Thomas Zimmermann (2): drm/amdgpu: Replace ttm_bo_reference with ttm_bo_get drm/amdgpu: Replace ttm_bo_unref with ttm_bo_put
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
-- 2.18.0
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put.
v2: * changed prefix to drm/amdgpu
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index b12526ce1a9d..f54d30186fd6 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c @@ -823,7 +823,7 @@ struct amdgpu_bo *amdgpu_bo_ref(struct amdgpu_bo *bo) if (bo == NULL) return NULL;
- ttm_bo_reference(&bo->tbo); + ttm_bo_get(&bo->tbo); return bo; }
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put.
A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. This is not necessary in most cases and sometimes even worked around by the calling code. A call to ttm_bo_put only releases the reference without clearing the pointer.
The current behaviour of cleaning the pointer is kept in the calling code, but should be removed if not required in a later patch.
v2: * set prefix to drm/amdgpu
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index f54d30186fd6..c5681477a3e2 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c @@ -841,9 +841,8 @@ void amdgpu_bo_unref(struct amdgpu_bo **bo) return;
tbo = &((*bo)->tbo); - ttm_bo_unref(&tbo); - if (tbo == NULL) - *bo = NULL; + ttm_bo_put(tbo); + *bo = NULL; }
/**
On Tue, Jul 31, 2018 at 09:12:34AM +0200, Thomas Zimmermann wrote:
This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions.
v2:
- use prefix drm/amdgpu
I guess Chritian will help to fix the subject prefix, you actually needn't send them again :-)
Thanks, Ray
Thomas Zimmermann (2): drm/amdgpu: Replace ttm_bo_reference with ttm_bo_get drm/amdgpu: Replace ttm_bo_unref with ttm_bo_put
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
-- 2.18.0
amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
dri-devel@lists.freedesktop.org
-
Huang Rui -
Thomas Zimmermann