Hi Dave,
You're pull just reminded me that I've been sitting on a few small -fixes, too. Nothing really major at all: - fixup edp setup sequence (Dave) - disable sdvo hotplug for real, this is a fixup for a messed-up regression fixer (Jani) - don't expose dysfunctional backlight driver (Jani) - properly init spinlock (only used by hsw/vlv code) from Alexander Shishkin
Wrt regression we have a new case of rc6-no-longer-working (times time it breaks after resume, investigation still going on) and one of the infoframe patches broke a screen on ilk (Paulo is looking into this one already).
Cheers, Daniel
The following changes since commit 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d:
Linux 3.6-rc4 (2012-09-01 10:39:58 -0700)
are available in the git repository at:
git://people.freedesktop.org/~danvet/drm-intel drm-intel-fixes
for you to fetch changes up to 99d0b1db6ccd0c0e554398e8a579ff3dd4d119ee:
drm/i915: initialize dpio_lock spin lock (2012-09-08 19:04:04 +0200)
---------------------------------------------------------------- Alexander Shishkin (1): drm/i915: initialize dpio_lock spin lock
Dave Airlie (1): drm/i915/edp: get the panel delay before powering up
Jani Nikula (2): drm/i915: only enable sdvo hotplug irq if needed drm/i915: do not expose a dysfunctional backlight interface to userspace
drivers/gpu/drm/i915/i915_dma.c | 1 + drivers/gpu/drm/i915/intel_dp.c | 11 +++++++---- drivers/gpu/drm/i915/intel_panel.c | 31 ++++++++++++++++++++++--------- drivers/gpu/drm/i915/intel_sdvo.c | 15 ++++++--------- 4 files changed, 36 insertions(+), 22 deletions(-)
On Mon, Sep 10, 2012 at 09:28:17AM +0200, Daniel Vetter wrote:
Hi Dave,
You're pull just reminded me that I've been sitting on a few small -fixes, too. Nothing really major at all:
- fixup edp setup sequence (Dave)
- disable sdvo hotplug for real, this is a fixup for a messed-up regression fixer (Jani)
- don't expose dysfunctional backlight driver (Jani)
- properly init spinlock (only used by hsw/vlv code) from Alexander Shishkin
Added one more: - fix a regression in the gen3 pageflip complete irq handling after resume (only affects some configurations, we've forgotten to restore a reg value).
Cheers, Daniel
The following changes since commit 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d:
Linux 3.6-rc4 (2012-09-01 10:39:58 -0700)
are available in the git repository at:
git://people.freedesktop.org/~danvet/drm-intel drm-intel-fixes
for you to fetch changes up to 974a3b0f9f05b748fe11f1afc31efc32aa5160cb:
drm/i915: set the right gen3 flip_done mode also at resume (2012-09-10 21:30:03 +0200)
---------------------------------------------------------------- Alexander Shishkin (1): drm/i915: initialize dpio_lock spin lock
Daniel Vetter (1): drm/i915: set the right gen3 flip_done mode also at resume
Dave Airlie (1): drm/i915/edp: get the panel delay before powering up
Jani Nikula (2): drm/i915: only enable sdvo hotplug irq if needed drm/i915: do not expose a dysfunctional backlight interface to userspace
drivers/gpu/drm/i915/i915_dma.c | 1 + drivers/gpu/drm/i915/i915_irq.c | 3 --- drivers/gpu/drm/i915/intel_dp.c | 11 +++++++---- drivers/gpu/drm/i915/intel_panel.c | 31 ++++++++++++++++++++++--------- drivers/gpu/drm/i915/intel_pm.c | 3 +++ drivers/gpu/drm/i915/intel_sdvo.c | 15 ++++++--------- 6 files changed, 39 insertions(+), 25 deletions(-)
On Mon, Sep 10, 2012 at 09:34:36PM +0200, Daniel Vetter wrote:
On Mon, Sep 10, 2012 at 09:28:17AM +0200, Daniel Vetter wrote:
Hi Dave,
You're pull just reminded me that I've been sitting on a few small -fixes, too. Nothing really major at all:
- fixup edp setup sequence (Dave)
- disable sdvo hotplug for real, this is a fixup for a messed-up regression fixer (Jani)
- don't expose dysfunctional backlight driver (Jani)
- properly init spinlock (only used by hsw/vlv code) from Alexander Shishkin
Added one more:
- fix a regression in the gen3 pageflip complete irq handling after resume (only affects some configurations, we've forgotten to restore a reg value).
And another small patch to shut up an overzealous WARN.
The following changes since commit 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d:
Linux 3.6-rc4 (2012-09-01 10:39:58 -0700)
are available in the git repository at:
git://people.freedesktop.org/~danvet/drm-intel drm-intel-fixes
for you to fetch changes up to 75c5da279e06577190abba52cabf0dc2a56edb97:
drm/i915: fix up the IBX transcoder B check (2012-09-11 17:25:14 +0200)
---------------------------------------------------------------- Alexander Shishkin (1): drm/i915: initialize dpio_lock spin lock
Daniel Vetter (2): drm/i915: set the right gen3 flip_done mode also at resume drm/i915: fix up the IBX transcoder B check
Dave Airlie (1): drm/i915/edp: get the panel delay before powering up
Jani Nikula (2): drm/i915: only enable sdvo hotplug irq if needed drm/i915: do not expose a dysfunctional backlight interface to userspace
drivers/gpu/drm/i915/i915_dma.c | 1 + drivers/gpu/drm/i915/i915_irq.c | 3 --- drivers/gpu/drm/i915/intel_display.c | 6 ++++-- drivers/gpu/drm/i915/intel_dp.c | 11 +++++++---- drivers/gpu/drm/i915/intel_panel.c | 31 ++++++++++++++++++++++--------- drivers/gpu/drm/i915/intel_pm.c | 3 +++ drivers/gpu/drm/i915/intel_sdvo.c | 15 ++++++--------- 7 files changed, 43 insertions(+), 27 deletions(-)
On Mon, Sep 10, 2012 at 12:28 AM, Daniel Vetter daniel@ffwll.ch wrote:
Hi Dave,
You're pull just reminded me that I've been sitting on a few small -fixes, too. Nothing really major at all:
- fixup edp setup sequence (Dave)
- disable sdvo hotplug for real, this is a fixup for a messed-up regression fixer (Jani)
- don't expose dysfunctional backlight driver (Jani)
Hi Daniel,
This change ("don't expose dysfunctional backlight driver") regresses the backlight on Chromebooks, where we don't run the vbios.
Stéphane
- properly init spinlock (only used by hsw/vlv code) from Alexander Shishkin
Wrt regression we have a new case of rc6-no-longer-working (times time it breaks after resume, investigation still going on) and one of the infoframe patches broke a screen on ilk (Paulo is looking into this one already).
Cheers, Daniel
The following changes since commit 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d:
Linux 3.6-rc4 (2012-09-01 10:39:58 -0700)
are available in the git repository at:
git://people.freedesktop.org/~danvet/drm-intel drm-intel-fixes
for you to fetch changes up to 99d0b1db6ccd0c0e554398e8a579ff3dd4d119ee:
drm/i915: initialize dpio_lock spin lock (2012-09-08 19:04:04 +0200)
Alexander Shishkin (1): drm/i915: initialize dpio_lock spin lock
Dave Airlie (1): drm/i915/edp: get the panel delay before powering up
Jani Nikula (2): drm/i915: only enable sdvo hotplug irq if needed drm/i915: do not expose a dysfunctional backlight interface to userspace
drivers/gpu/drm/i915/i915_dma.c | 1 + drivers/gpu/drm/i915/intel_dp.c | 11 +++++++---- drivers/gpu/drm/i915/intel_panel.c | 31 ++++++++++++++++++++++--------- drivers/gpu/drm/i915/intel_sdvo.c | 15 ++++++--------- 4 files changed, 36 insertions(+), 22 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, May 22, 2013 at 3:24 AM, Stéphane Marchesin stephane.marchesin@gmail.com wrote:
On Mon, Sep 10, 2012 at 12:28 AM, Daniel Vetter daniel@ffwll.ch wrote:
Hi Dave,
You're pull just reminded me that I've been sitting on a few small -fixes, too. Nothing really major at all:
- fixup edp setup sequence (Dave)
- disable sdvo hotplug for real, this is a fixup for a messed-up regression fixer (Jani)
- don't expose dysfunctional backlight driver (Jani)
Hi Daniel,
This change ("don't expose dysfunctional backlight driver") regresses the backlight on Chromebooks, where we don't run the vbios.
Presuming the patch works as advertised it only stops publishing an intel backlight driver which won't work. How does that break stuff?
Or do you somehow update the max blc stuff only once i915.ko is loaded?
I'm decently confused how that one blows up ...
Yours, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
On Wed, May 22, 2013 at 12:13 AM, Daniel Vetter daniel@ffwll.ch wrote:
On Wed, May 22, 2013 at 3:24 AM, Stéphane Marchesin stephane.marchesin@gmail.com wrote:
On Mon, Sep 10, 2012 at 12:28 AM, Daniel Vetter daniel@ffwll.ch wrote:
Hi Dave,
You're pull just reminded me that I've been sitting on a few small -fixes, too. Nothing really major at all:
- fixup edp setup sequence (Dave)
- disable sdvo hotplug for real, this is a fixup for a messed-up regression fixer (Jani)
- don't expose dysfunctional backlight driver (Jani)
Hi Daniel,
This change ("don't expose dysfunctional backlight driver") regresses the backlight on Chromebooks, where we don't run the vbios.
Presuming the patch works as advertised it only stops publishing an intel backlight driver which won't work. How does that break stuff?
Well it probably works as advertised to avoid exposing some broken backlight, but the problem is that it also stops exposing a working backlight on Chromebooks. However it sounds like the initial patch is specific to a broken machine, so maybe a dmi match is more appropriate?
Or do you somehow update the max blc stuff only once i915.ko is loaded?
Yup that's what used to happen.
Stéphane
I'm decently confused how that one blows up ...
Yours, Daniel
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
On Wed, May 22, 2013 at 5:25 PM, Stéphane Marchesin stephane.marchesin@gmail.com wrote:
On Wed, May 22, 2013 at 12:13 AM, Daniel Vetter daniel@ffwll.ch wrote:
On Wed, May 22, 2013 at 3:24 AM, Stéphane Marchesin stephane.marchesin@gmail.com wrote:
On Mon, Sep 10, 2012 at 12:28 AM, Daniel Vetter daniel@ffwll.ch wrote:
Hi Dave,
You're pull just reminded me that I've been sitting on a few small -fixes, too. Nothing really major at all:
- fixup edp setup sequence (Dave)
- disable sdvo hotplug for real, this is a fixup for a messed-up regression fixer (Jani)
- don't expose dysfunctional backlight driver (Jani)
Hi Daniel,
This change ("don't expose dysfunctional backlight driver") regresses the backlight on Chromebooks, where we don't run the vbios.
Presuming the patch works as advertised it only stops publishing an intel backlight driver which won't work. How does that break stuff?
Well it probably works as advertised to avoid exposing some broken backlight, but the problem is that it also stops exposing a working backlight on Chromebooks. However it sounds like the initial patch is specific to a broken machine, so maybe a dmi match is more appropriate?
I prefer a dmi match for chromebooks since the behaviour of fixing up the backlight after i915.ko is loaded seems rather peculiar to your setup.
Or do you somehow update the max blc stuff only once i915.ko is loaded?
Yup that's what used to happen.
What/when exactly does that happen? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
On Wed, May 22, 2013 at 8:51 AM, Daniel Vetter daniel@ffwll.ch wrote:
On Wed, May 22, 2013 at 5:25 PM, Stéphane Marchesin stephane.marchesin@gmail.com wrote:
On Wed, May 22, 2013 at 12:13 AM, Daniel Vetter daniel@ffwll.ch wrote:
On Wed, May 22, 2013 at 3:24 AM, Stéphane Marchesin stephane.marchesin@gmail.com wrote:
On Mon, Sep 10, 2012 at 12:28 AM, Daniel Vetter daniel@ffwll.ch wrote:
Hi Dave,
You're pull just reminded me that I've been sitting on a few small -fixes, too. Nothing really major at all:
- fixup edp setup sequence (Dave)
- disable sdvo hotplug for real, this is a fixup for a messed-up regression fixer (Jani)
- don't expose dysfunctional backlight driver (Jani)
Hi Daniel,
This change ("don't expose dysfunctional backlight driver") regresses the backlight on Chromebooks, where we don't run the vbios.
Presuming the patch works as advertised it only stops publishing an intel backlight driver which won't work. How does that break stuff?
Well it probably works as advertised to avoid exposing some broken backlight, but the problem is that it also stops exposing a working backlight on Chromebooks. However it sounds like the initial patch is specific to a broken machine, so maybe a dmi match is more appropriate?
I prefer a dmi match for chromebooks since the behaviour of fixing up the backlight after i915.ko is loaded seems rather peculiar to your setup.
It has nothing to do with Chromebooks though, but more with the fact that we don't run vbios. This isn't a property of the hardware.
Or do you somehow update the max blc stuff only once i915.ko is loaded?
Yup that's what used to happen.
What/when exactly does that happen?
Before the regression, the code was:
if (max == 0) { i915_set_default_max_backlight
which would make it work. And now that doesn't run and therefore it breaks.
Stéphane
-Daniel
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
dri-devel@lists.freedesktop.org
-
Daniel Vetter -
Stéphane Marchesin