From: Markus Elfring elfring@users.sourceforge.net Date: Sat, 19 Dec 2015 12:48:31 +0100
The return type "unsigned int" was used by the do_relocs() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type qualifier then.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- drivers/gpu/host1x/job.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index 63bd63f..1919aab 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -225,7 +225,7 @@ unpin: return 0; }
-static unsigned int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) +static int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) { int i = 0; u32 last_page = ~0;
On Sat, Dec 19, 2015 at 12:56:54PM +0100, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Sat, 19 Dec 2015 12:48:31 +0100
The return type "unsigned int" was used by the do_relocs() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type qualifier then.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net
drivers/gpu/host1x/job.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Good catch. Applied, thanks.
Thierry
dri-devel@lists.freedesktop.org