On Sat, Aug 7, 2021 at 7:38 PM Randy Dunlap rdunlap@infradead.org wrote:

Don't use "begin kernel-doc notation" (/**) for comments that are not kernel-doc. This eliminates warnings reported by the 0day bot.

drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:89: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * This shader is used to clear VGPRS and LDS, and also write the input drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:209: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * The below shaders are used to clear SGPRS, and also write the input drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:301: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * This shader is used to clear the uninitiated sgprs after the above

Fixes: 0e0036c7d13b ("drm/amdgpu: fix no full coverage issue for gprs initialization") Signed-off-by: Randy Dunlap rdunlap@infradead.org Reported-by: kernel test robot lkp@intel.com Cc: Alex Deucher alexander.deucher@amd.com Cc: Christian König christian.koenig@amd.com Cc: "Pan, Xinhui" Xinhui.Pan@amd.com Cc: Dennis Li Dennis.Li@amd.com Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org

Applied. Thanks!

Alex

---

drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-next-20210806.orig/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c +++ linux-next-20210806/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c @@ -85,7 +85,7 @@ static const struct soc15_reg_golden gol SOC15_REG_GOLDEN_VALUE(GC, 0, regTCI_CNTL_3, 0xff, 0x20), };

-/** +/*

• This shader is used to clear VGPRS and LDS, and also write the input
• pattern into the write back buffer, which will be used by driver to
• check whether all SIMDs have been covered.

@@ -206,7 +206,7 @@ const struct soc15_reg_entry vgpr_init_r { SOC15_REG_ENTRY(GC, 0, regCOMPUTE_STATIC_THREAD_MGMT_SE7), 0xffffffff }, };

-/** +/*

• The below shaders are used to clear SGPRS, and also write the input
• pattern into the write back buffer. The first two dispatch should be
• scheduled simultaneously which make sure that all SGPRS could be

@@ -302,7 +302,7 @@ const struct soc15_reg_entry sgpr96_init { SOC15_REG_ENTRY(GC, 0, regCOMPUTE_STATIC_THREAD_MGMT_SE7), 0xffffffff }, };

-/** +/*

• This shader is used to clear the uninitiated sgprs after the above
• two dispatches, because of hardware feature, dispath 0 couldn't clear
• top hole sgprs. Therefore need 4 waves per SIMD to cover these sgprs