size contain non-negative value since it is declared as uint32_t. So below statement is always false. if (size < 0)
Remove unnecessary comparison.
Signed-off-by: Austin Kim austindh.kim@gmail.com --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 12c0e46..3c7c68e 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -1134,9 +1134,6 @@ static int navi10_set_power_profile_mode(struct smu_context *smu, long *input, u }
if (smu->power_profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) { - if (size < 0) - return -EINVAL; - ret = smu_update_table(smu, SMU_TABLE_ACTIVITY_MONITOR_COEFF, WORKLOAD_PPLIB_CUSTOM_BIT, (void *)(&activity_monitor), false);
Reviewed-by: Kevin Wang kevin1.wang@amd.com
Best Regards, Kevin ________________________________ From: amd-gfx amd-gfx-bounces@lists.freedesktop.org on behalf of Austin Kim austindh.kim@gmail.com Sent: Monday, September 9, 2019 12:31 PM To: Deucher, Alexander Alexander.Deucher@amd.com; airlied@linux.ie airlied@linux.ie; daniel@ffwll.ch daniel@ffwll.ch Cc: Zhou, David(ChunMing) David1.Zhou@amd.com; amd-gfx@lists.freedesktop.org amd-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org dri-devel@lists.freedesktop.org; Koenig, Christian Christian.Koenig@amd.com Subject: [PATCH] drm/amd/powerplay: Remove unnecessary comparison statement
size contain non-negative value since it is declared as uint32_t. So below statement is always false. if (size < 0)
Remove unnecessary comparison.
Signed-off-by: Austin Kim austindh.kim@gmail.com --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 12c0e46..3c7c68e 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -1134,9 +1134,6 @@ static int navi10_set_power_profile_mode(struct smu_context *smu, long *input, u }
if (smu->power_profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) { - if (size < 0) - return -EINVAL; - ret = smu_update_table(smu, SMU_TABLE_ACTIVITY_MONITOR_COEFF, WORKLOAD_PPLIB_CUSTOM_BIT, (void *)(&activity_monitor), false); -- 2.6.2
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
dri-devel@lists.freedesktop.org
-
Austin Kim -
Wang, Kevin(Yang)